Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115964
MIME-Version: 1.0
References: <CADJ56BRPi_GHE7R70k-NdgQ6ea2ogLSe6Z6Eg-YGKpeYSmvhbQ@mail.gmail.com>
 <CAJvSBVP2pCT6wDNrpVDp=1_JQtrG=H2Y2fy8L-vcvgawhWstCw@mail.gmail.com>
 <CADJ56BSHDTZ86oRqMHfsB860WXsO3ORv7JVGArJx+Q7FN4nD5g@mail.gmail.com>
 <0A048A30-444F-4DB0-A79C-9EA9BD07B1EC@cschneid.com> <CADJ56BT=TDF2_fn5ci-=34cuMSeks5NzA4r5_5acVNum9PY_kw@mail.gmail.com>
 <CAF+90c-qjOvu6UefGGba2NdRkhRovWq1sUCOfs6+Odt1eLJm+Q@mail.gmail.com>
 <569E3A48-E3F5-46FA-BA08-D2493CE4FD33@cschneid.com> <CADJ56BS08Q4-5iZdTG0=+XKSwD5T=be-Q8VWbX2NhqMmfZkmbg@mail.gmail.com>
 <9B6A493C-DBA6-4CF0-9AE2-DAA0A700A7D2@cschneid.com> <CADJ56BRrsV8sPy3eDjp=FCobp2BKKwZvOOovsvxDw0Hf35S5Bg@mail.gmail.com>
 <CAJmy8YGD_UHM=Aj5NaFHhAyp9mVgpiF1mN_zT0y2jygE1U7Znw@mail.gmail.com>
 <CAEPJdunH11Pso4YS0fE4JAbcAAo5anf1s2D-oZoi7+MT8FNu2w@mail.gmail.com>
 <CAEZPtU4D27+=ygRbTsrZcPzYd9GMge9myTh3C0LqzxBsMD+ftQ@mail.gmail.com> <88103087-61a5-8f89-a146-0a77d8d28e84@gmx.de>
In-Reply-To: <88103087-61a5-8f89-a146-0a77d8d28e84@gmx.de>
Date: Mon, 6 Sep 2021 21:46:12 +0700
Message-ID: <CAEZPtU4t8aNKL0XixGJmQ4mV3oX=oUWeJ8w_gh+TJMCAq0R_7g@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Benjamin Eberlei <kontakt@beberlei.de>, Hans Henrik Bergan <divinity76@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Adding a way to disable the stat cache
From: pierre.php@gmail.com (Pierre Joye)

On Mon, Sep 6, 2021 at 7:05 PM Christoph M. Becker <cmbecker69@gmx.de> wrote:
>
> On 06.09.2021 at 14:00, Pierre Joye wrote:
>
> > On Mon, Sep 6, 2021, 6:14 PM Benjamin Eberlei <kontakt@beberlei.de> wrote:
> >
> >> On Fri, Sep 3, 2021 at 11:51 PM Hans Henrik Bergan <divinity76@gmail.com>
> >> wrote:
> >>
> >> The stat cache does not necessarily solve this issues though, only in very
> >> limited cases where you work with the *same* file over and over again. The
> >> stat cache only ever has exactly one entry, the *last* file that was
> >> accessed. So if you work with many diferent files the stat cache does not
> >> do what you would expect, to store the information of all these files. It
> >> overwrites the cache with a new file entry when its not the same file as
> >> currently stored.
> >
> > that is what happened in TS mode. For every part of a path, every single
> > time a path is used (like source files in a common root path). I did not
> > check it lately but I suppose it still does it.
>
> This is the realpath cache, though.

realpath(path, 1) does not do stat anymore? I mean with
virtual_file_ex and co? Not so important, too long since I touched
this :)

Also as someone mentioned here afterwards, instead of removing it
straight away, I would go with the flag first, less risky :)

best,
-- 
Pierre

@pierrejoye | http://www.libgd.org