Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115956
Return-Path: <kevin@ie.suberic.net>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 92028 invoked from network); 5 Sep 2021 10:53:44 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 5 Sep 2021 10:53:44 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id DBF1E180539
	for <internals@lists.php.net>; Sun,  5 Sep 2021 04:30:41 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.2
X-Spam-ASN: AS15169 209.85.128.0/17
X-Spam-Virus: No
X-Envelope-From: <kevin@ie.suberic.net>
Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Sun,  5 Sep 2021 04:30:41 -0700 (PDT)
Received: by mail-pj1-f49.google.com with SMTP id d5so2537601pjx.2
        for <internals@lists.php.net>; Sun, 05 Sep 2021 04:30:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=ie.suberic.net; s=google;
        h=mime-version:references:in-reply-to:reply-to:from:date:message-id
         :subject:to;
        bh=s5CWT5pATDCmKZRRHqfn4vHbDQPxfn2LkSUGUKEkzmc=;
        b=cs/Gbp7GL2Irhb9x1vtG3z0nREdqx7UhA0+3Tg/HT0MVjKePtDIaRWtO9SJudPLwcf
         aGs88HM/jzlpoPg3w3H4/ivNABaCHO3fV8ghUoxRCvYxxic/py73/ExFS1yMQdQE2ryi
         NAejoIxWcc8Jd8aBzu6LEcNQrgZ6pIpHshpLI=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:reply-to
         :from:date:message-id:subject:to;
        bh=s5CWT5pATDCmKZRRHqfn4vHbDQPxfn2LkSUGUKEkzmc=;
        b=TTIn1VkGNkTJyUUTmNzqUnLQ0e3/dpM4uzAybmGq82h/Wq+2EWCN9KnTmkJw/7b3BT
         ak9YsnggAZtaLfQ0doPTpyBEgZDa5qmOzjQvO2zmwaOG/XokSPXfa5ZsX9gtyoQ3eHvN
         PBK6DOq1gkVJfLDToQfENH3RS6uznbUOqVexQauSMAMNU7LUa9P+tZdk6x8WcvyP7zVW
         X2rscYeew56IjiZbvRUWir4PzfpTmGseK9yIKf34S8lyS30Jst0QMqYlfl0Bokuct85C
         VyDkkTiGiypQDFYPBwX8FYQMgT8fjbyizvUtxk1PuzB14pgAUIjYMKWp/OW0ysowPu9e
         iKaA==
X-Gm-Message-State: AOAM530DsQxDArcVJ4MLOBSLA5skgtLNdhMZn9NxAu2qTRnQHG0zPg24
	+Ky32T80LLVJ3Y94P1Dmy8+xSVP6Mu+d+g3CEWrB40x3p6n//Q==
X-Google-Smtp-Source: ABdhPJytSB5OpHzoU0GTIWkKcFy1ZfyeGG22ThM9kAtHY9pGrYtvHusr0D0CBC5VbUmTCrBqyeGo6rpg70nUcIThz1M=
X-Received: by 2002:a17:90a:f2c4:: with SMTP id gt4mr8746375pjb.219.1630841436805;
 Sun, 05 Sep 2021 04:30:36 -0700 (PDT)
MIME-Version: 1.0
References: <CADJ56BRPi_GHE7R70k-NdgQ6ea2ogLSe6Z6Eg-YGKpeYSmvhbQ@mail.gmail.com>
In-Reply-To: <CADJ56BRPi_GHE7R70k-NdgQ6ea2ogLSe6Z6Eg-YGKpeYSmvhbQ@mail.gmail.com>
Reply-To: kevin@lyda.ie
Date: Sun, 5 Sep 2021 12:30:26 +0100
Message-ID: <CADJ56BTJvTNaaXW+DOc0+bcnsjdGcEje6ggy3TrA13Kcnc+STg@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: Adding a way to disable the stat cache
From: kevin@ie.suberic.net (Kevin Lyda)

Any more thoughts on https://github.com/php/php-src/pull/5894 ?

I've resolved the merge conflict. It would be nice to close out this bug.

Kevin

On Thu, Sep 2, 2021 at 9:27 AM Kevin Lyda <kevin@ie.suberic.net> wrote:
>
> PHP has a stat cache which is... unfortunate. As noted in this bug from
> 2004[0] it causes a number of issues for PHP users and is irrelevant
> in modern operating systems. Heck, it's not even useful in OS's people
> might consider ancient at this point.
>
> I have a PR[1] to fix this, but had not noticed it had been referred to
> this mailing list.  I'll need fix the PR at this point as the code has
> drifted, but before I do, can whatever discussion happen so that the PR
> will be accepted?  The change I've made will allow people to disable the
> cache so that it won't cause errors and it leaves the current broken
> behaviour in place.  So there's no real change to the user experience
> except they now have a tool to disable buggy behaviour.  I feel that
> this is the least intrusive way to fix this bug.
>
> In the discussion on the bug there was resistance to getting rid of the
> cache so this was the solution proposed in 2007 and seemed reasonable.
> The default behaviour remains but can be turned off by people who want
> it off - and there are a number of people who would like it off.
>
> Is this an acceptable solution? Would this functionality be accepted
> either via my PR or another.
>
> Kevin
>
> [0]: https://bugs.php.net/bug.php?id=28790
> [1]: https://github.com/php/php-src/pull/5894
>
> --
> Kevin Lyda
> Galway, Ireland



-- 
Kevin Lyda
Galway, Ireland