Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115954
MIME-Version: 1.0
References: <CABTDVhBRpD=nWBk2xGLEmdcWwOzCeqGeqH5vLSugPFOeEN9Mog@mail.gmail.com>
 <e36f746e-47db-aa93-4382-cd5a4cc14439@mabe.berlin>
In-Reply-To: <e36f746e-47db-aa93-4382-cd5a4cc14439@mabe.berlin>
Date: Sun, 5 Sep 2021 13:13:15 +0900
Message-ID: <CABTDVhBa5+YuQtq5xumRGP_tJ_A7oGO4qgs1inad49bVtkegzQ@mail.gmail.com>
To: Marc <marc@mabe.berlin>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000102f4805cb37c11f"
Subject: Re: [PHP-DEV] [RFC] Random Extension 3.0
From: zeriyoshi@gmail.com (Go Kudo)

--000000000000102f4805cb37c11f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks marc.

> "shuffleString()" works on byte level and so it should be
"shuffleBytes()".

Hmm. This may be a difficult problem related to the PHP language
specification. As with `str_shuffle()`, most people will probably use it to
shuffle strings. People who want to shuffle binaries are likely to
understand that in PHP it is synonymous with `shuffleBytes()`.

> Why are there no default values for min/max on "getInt()" - It seems
unnecessary to me to pass min/max arguments

My apologies. I completely forgot that I needed this.
Add this along with a fix for the RNG\NumberGenerator implementation.

Regards,
Go Kudo

2021=E5=B9=B49=E6=9C=885=E6=97=A5(=E6=97=A5) 5:57 Marc <marc@mabe.berlin>:

>
> On 9/2/21 5:10 PM, Go Kudo wrote:
> > Hi Internals.
> >
> > Expanded from the previous RFC and changed it to an RFC that organizes
> the
> > whole PHP random number generator. Also, the target version has been
> > changed to 8.2.
> >
> > https://wiki.php.net/rfc/rng_extension
> > https://github.com/php/php-src/pull/7453
> >
> > Hopefully you will get some good responses.
>
> For me (user land developer with no voting power) your RFC looks pretty :=
)
>
> Beside the abstract vs interface question I have some other notes:
>
> On the one hand you define "getBytes()" which returns a string and on
> the other hand you define "shuffleString()" - is the first one a binary
> string and the other a charset dependent string? I guess here
> "shuffleString()" works on byte level and so it should be "shuffleBytes()=
".
>
> Why are there no default values for min/max on "getInt()" - It seems
> unnecessary to me to pass min/max arguments if you are just interested
> in a random integer or passing max as well if you are interested in a
> positive integer only.
>
> Thanks for the nice RFC!
>
> > Regards,
> > Go Kudo
> Marc
>

--000000000000102f4805cb37c11f--