Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115929
User-Agent: Cyrus-JMAP/3.5.0-alpha0-1126-g6962059b07-fm-20210901.001-g6962059b
Mime-Version: 1.0
Message-ID: <abfb24a4-bce5-4abc-b2ec-404c571f46ea@www.fastmail.com>
In-Reply-To: 
 <CABTDVhDufAQMvHJqe6fF5Jz+t0Wo+hbRA0A7KA1jh9ZPBeR2Eg@mail.gmail.com>
References: 
 <CABTDVhBRpD=nWBk2xGLEmdcWwOzCeqGeqH5vLSugPFOeEN9Mog@mail.gmail.com>
 <6921b613-d993-4e5b-82a7-60e3c9b3df38@www.fastmail.com>
 <CABTDVhDufAQMvHJqe6fF5Jz+t0Wo+hbRA0A7KA1jh9ZPBeR2Eg@mail.gmail.com>
Date: Fri, 03 Sep 2021 09:03:58 -0500
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain
Subject: Re: [PHP-DEV] [RFC] Random Extension 3.0
From: larry@garfieldtech.com ("Larry Garfield")

On Fri, Sep 3, 2021, at 8:55 AM, Go Kudo wrote:
> Thank you.
> 
> > Why is the number generator a parent class rather than an interface?
> 
> This is an implementation limitation. I could not find a way to define my
> own object handler in interface.
> As Nikita pointed out in a previous suggestion, the NumberGenerator now
> uses php_random_ng_algo_user to generate random numbers faster than before,
> even if it is a userland implementation.

I'm still unclear how I'd write my own NumberGenerator right now.  I mean, I can extend the class, but I don't have a sense for what I'd do with it for non-testing/trivial implementations.  You say it's using an internal function to generate numbers, but in user space what would I do with that?  And when/why would I?

> > You don't mention the CSPRNG functions at all.
> 
> This is a mistake. I have corrected it. Thanks!

I'm still not clear on the intent here.  Is the intent that I should stop using random_int()?  And if so, replace it with... what?  Do I have to supply a specific non-default generator?  That makes the usability worse, and more likely to be gotten wrong.

Also, in future scope you you have this sentence, which makes little sense:

>> Replace random_bytes() with random_bytes() for random numbers used in shuffle(), str_shuffle(), and array_rand().

--Larry Garfield