Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115922
User-Agent: Cyrus-JMAP/3.5.0-alpha0-1126-g6962059b07-fm-20210901.001-g6962059b
Mime-Version: 1.0
Message-ID: <6921b613-d993-4e5b-82a7-60e3c9b3df38@www.fastmail.com>
In-Reply-To: 
 <CABTDVhBRpD=nWBk2xGLEmdcWwOzCeqGeqH5vLSugPFOeEN9Mog@mail.gmail.com>
References: 
 <CABTDVhBRpD=nWBk2xGLEmdcWwOzCeqGeqH5vLSugPFOeEN9Mog@mail.gmail.com>
Date: Thu, 02 Sep 2021 13:26:12 -0500
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain
Subject: Re: [PHP-DEV] [RFC] Random Extension 3.0
From: larry@garfieldtech.com ("Larry Garfield")

On Thu, Sep 2, 2021, at 10:10 AM, Go Kudo wrote:
> Hi Internals.
> 
> Expanded from the previous RFC and changed it to an RFC that organizes the
> whole PHP random number generator. Also, the target version has been
> changed to 8.2.
> 
> https://wiki.php.net/rfc/rng_extension
> https://github.com/php/php-src/pull/7453
> 
> Hopefully you will get some good responses.
> 
> Regards,
> Go Kudo

This looks pretty nice to my unskilled eye.  Two questions.

1) Why is the number generator a parent class rather than an interface?  It seems like an interface target.  And either way it needs more clarity about how you'd write one for reals.  (It returns an int, so does that mean getBytes() just derives from a series of ints?)

2) You don't mention the CSPRNG functions at all.  Is there any intention to fold those into this model as well, or to leave those as is?  Or is the Secure generator implementation intended to replace those?  It's unclear here.

--Larry Garfield