Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:115912 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 8955 invoked from network); 2 Sep 2021 07:51:07 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 2 Sep 2021 07:51:07 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id BBB761804AD for ; Thu, 2 Sep 2021 01:27:18 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.7 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Thu, 2 Sep 2021 01:27:18 -0700 (PDT) Received: by mail-pj1-f44.google.com with SMTP id l3so845053pji.5 for ; Thu, 02 Sep 2021 01:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ie.suberic.net; s=google; h=mime-version:reply-to:from:date:message-id:subject:to; bh=yBKiphYT9T4ZDhGJlonfhSZuRSi09jmXkmpuzXNE/Ws=; b=e3ZDMn08dGcDR1G9wLTyKm7tOSnANNwgz7Hh8PGfOgYM7fQbwHkA4V7q2Mf4lQOmW5 rv7TNzFAbrcZiQ6UsCyOIHUh8G4FQe+J9CPZP6fuc+3kOQWgSczNdkhClgAKuTqlDyEB gJBCOMxUqheZuhflZ5q5Kjmod5xlZgbiZO6po= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:from:date:message-id :subject:to; bh=yBKiphYT9T4ZDhGJlonfhSZuRSi09jmXkmpuzXNE/Ws=; b=UvGgIy6f5yhb8oZPToPsIz8kZv8YktifgJPRRDjIKvOe40zybUahox1xc/rrYrVue5 /0SeZiMv78IDPjyaRep/d9EVJkAAtsxqpcocguxUB7H/srbiPLkEV6SVTFC8bXVmgz32 7SIl3GJqj0eEnS+1VDBI0jd8ZiJthYFtaVGCR3zktVIdsE2PpeQjbZFjtMOLcPjfoAze LOGCr7HBP+MeG3t6ZmpnshkwqAFYVZCc3xVyrX1ImryR04tSidL5SGd0DZcvnSfg5y5T 6Wm5DBHM2R9z+teHd150MFGAV10GMIskcpfC0NgtLN4jvFOz+iiQOpxl+8c8i96BXT3q FWyg== X-Gm-Message-State: AOAM5333IWLv6WgBlXSm93cpAf1+GEdBG4wBLUKKLknu3rfsyA/Y+Bmh 4c5N9OATsPQpVjPD7khmyfphLX4SfrMYOKAhw6HxSOB7V7u+cQ== X-Google-Smtp-Source: ABdhPJxsAe6cTlZ8BW0BM1VR2OzAwEvGhE9RIThdZfLju/Gxh9WZot2Z0lAs3JMb14s0tFm6F8tFw0pV6WC4zdRGFYw= X-Received: by 2002:a17:90a:1990:: with SMTP id 16mr2641125pji.11.1630571236341; Thu, 02 Sep 2021 01:27:16 -0700 (PDT) MIME-Version: 1.0 Reply-To: kevin@lyda.ie Date: Thu, 2 Sep 2021 09:27:05 +0100 Message-ID: To: internals@lists.php.net Content-Type: text/plain; charset="UTF-8" Subject: Adding a way to disable the stat cache From: kevin@ie.suberic.net (Kevin Lyda) PHP has a stat cache which is... unfortunate. As noted in this bug from 2004[0] it causes a number of issues for PHP users and is irrelevant in modern operating systems. Heck, it's not even useful in OS's people might consider ancient at this point. I have a PR[1] to fix this, but had not noticed it had been referred to this mailing list. I'll need fix the PR at this point as the code has drifted, but before I do, can whatever discussion happen so that the PR will be accepted? The change I've made will allow people to disable the cache so that it won't cause errors and it leaves the current broken behaviour in place. So there's no real change to the user experience except they now have a tool to disable buggy behaviour. I feel that this is the least intrusive way to fix this bug. In the discussion on the bug there was resistance to getting rid of the cache so this was the solution proposed in 2007 and seemed reasonable. The default behaviour remains but can be turned off by people who want it off - and there are a number of people who would like it off. Is this an acceptable solution? Would this functionality be accepted either via my PR or another. Kevin [0]: https://bugs.php.net/bug.php?id=28790 [1]: https://github.com/php/php-src/pull/5894 -- Kevin Lyda Galway, Ireland