Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115908
MIME-Version: 1.0
References: <CAPVMwwu0DENYHEWS_3aP5QNR4C8=4+Xxq2To=KyraxM5b2tPoQ@mail.gmail.com>
 <CAEZPtU6fQ-YGrx0Y+prWRdGxxZ2tJqonoUQx5FOUcnFm4_5Uhw@mail.gmail.com>
In-Reply-To: <CAEZPtU6fQ-YGrx0Y+prWRdGxxZ2tJqonoUQx5FOUcnFm4_5Uhw@mail.gmail.com>
Date: Wed, 1 Sep 2021 00:18:27 +0300
Message-ID: <CAJW__o2H3uU7VzQjXUQOraEUtvoSnh4udVdxj30USOerTK9Qpw@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: Dmitry Stogov <dmitrystogov@gmail.com>, Derick Rethans <derick@php.net>, 
	PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] timelib performance fix
From: kalle@php.net (Kalle Sommer Nielsen)

Den tir. 31. aug. 2021 kl. 09.10 skrev Pierre Joye <pierre.php@gmail.com>:
> It is late in the run to include it, but if RMs are OK, I would be all
> for applying it. The lib is bundled and whether the external
> repository applies it should not be relevant at this point (also no
> activity in 2 years there), or?

The external library is important because you can update the pecl
release of that in the middle of a PHP release if an update comes out,
which is good if you are locked to a specific version of PHP. Loading
in the pecl/timelib extension will override the internal version,
however if this fix is only applied to the bundled library, but not
synced upstream, then it breaks this philosophy.


-- 
regards,

Kalle Sommer Nielsen
kalle@php.net