Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:115905 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 59330 invoked from network); 31 Aug 2021 13:56:52 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 31 Aug 2021 13:56:52 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 224FF180538 for ; Tue, 31 Aug 2021 07:32:33 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_NEUTRAL autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS30827 82.113.144.0/21 X-Spam-Virus: No X-Envelope-From: Received: from xdebug.org (xdebug.org [82.113.146.227]) by php-smtp4.php.net (Postfix) with ESMTP for ; Tue, 31 Aug 2021 07:32:32 -0700 (PDT) Received: from localhost (localhost [IPv6:::1]) by xdebug.org (Postfix) with ESMTPS id 94AAA10C025; Tue, 31 Aug 2021 15:32:31 +0100 (BST) Date: Tue, 31 Aug 2021 15:32:31 +0100 (BST) X-X-Sender: derick@singlemalt.home.derickrethans.nl To: Dmitry Stogov cc: PHP Internals In-Reply-To: Message-ID: References: User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [PHP-DEV] timelib performance fix From: derick@php.net (Derick Rethans) Hi Dmitry, On Mon, 30 Aug 2021, Dmitry Stogov wrote: > Please, let me know you decision according > https://github.com/derickr/timelib/pull/99 > > This workaround fix makes ~170 times improvement on "new DateTimeZone()" > and as result visible improvement on some real-life apps (e.g Symfony demo > gets ~7% according to callgrind). > This is a huge difference. > > The fix was proposed more than a half year ago... > It would be great to include it into PHP-8.1 release. I'd seen the original PR, which still had "changes requested" open, but I've had a look now and instead of picking an arbitrary limit, we're actually respecting the POSIX system limit (which is 6, usually). Merged into PHP's master (among another bug fix) too. cheers, Derick -- PHP 7.4 Release Manager Host of PHP Internals News: https://phpinternals.news Like Xdebug? Consider supporting me: https://xdebug.org/support https://derickrethans.nl | https://xdebug.org | https://dram.io twitter: @derickr and @xdebug