Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:115900 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 20302 invoked from network); 31 Aug 2021 05:34:53 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 31 Aug 2021 05:34:53 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 004821804D8 for ; Mon, 30 Aug 2021 23:10:31 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 30 Aug 2021 23:10:30 -0700 (PDT) Received: by mail-oi1-f182.google.com with SMTP id s20so23155531oiw.3 for ; Mon, 30 Aug 2021 23:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LgIC5j3pz5ZsMOqbgDd/ZUqq1FKr1n5EA9YH1znWICQ=; b=Ki4v/3cOisSNBr/Sz3qMN9dtmzyezhTwjF3wXxXUI8NuXppVL7YpPS79vlRcokBS13 JdEX1yzRlITD/oQN1MONMmnlwx74NdK1fEQO2EEG4+ueUfXHjyOMhqKdnXVdt2hC9axg /+ljO0oCXDp61TgEjL1syJmEXJEydJqCDJS/YE1F7CR/igQkirKivhdue6Bp7Ujqf/W3 mAus0uhKkFRChlh3UX0oQeAmzTnN60eSWJv2IWELp2whbcyOTslXUgxioSIOTFICmrCV JuQFVA9UddXuNhvZkAasbTtTSeXZB4Jr6+u9aQhc9h7go+akbSRlZugTEbHr4/z76wLD 0buA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LgIC5j3pz5ZsMOqbgDd/ZUqq1FKr1n5EA9YH1znWICQ=; b=kLkyCCTxm+Dt7yicnbBxwuwu84XzuBdVbATgJyTG8s34iwsKWmQd/bM2QFk7jEuOwm ixTvGD3EF6jqs3Slh4j424VKsIw1w4SELbfSMd7A+Pqo0Zk2TzIvEtq7ASyPb9biNXQD hz+Ok9Zvsh5yy4yImac+93u4XgFS85ToX4gzZNl/5akfKXW43tbUqMKunf859QuPo0TA zNMgWxEGV7rtTpO7kkJjA2q79yrKYoc0bXkkGgxLUNnG16kTGjio5eoj6T+F3/R3Cpf6 ei4rng3ODuQ2LdSpXrBQMfapJkZLeKoLyR9NwNRe0bwSFHVxWkBLlbiXK2Ca2DJYWPzl tT+A== X-Gm-Message-State: AOAM530PnKly2/t3qq2zDnKWByw9WlOSUozwDfwwGfrpuFC1ms5HVlb/ kGIAU+K/hC6Ln+tARyB3hoBDZuQzptNUBQh19PU= X-Google-Smtp-Source: ABdhPJyYsE7Vd0t7hA/X82vtX8eKcMcr3pZJcQ1zy/3xgBh4ji9YCjhet5hWU0wEz36dkTx1fr3StMRzwqUttCx5D3Y= X-Received: by 2002:a05:6808:3d9:: with SMTP id o25mr2048344oie.168.1630390229744; Mon, 30 Aug 2021 23:10:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Tue, 31 Aug 2021 13:10:18 +0700 Message-ID: To: Dmitry Stogov Cc: Derick Rethans , PHP Internals Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] timelib performance fix From: pierre.php@gmail.com (Pierre Joye) Hi Dmitry, On Mon, Aug 30, 2021 at 8:54 PM Dmitry Stogov wrote: > Please, let me know you decision according > https://github.com/derickr/timelib/pull/99 > > This workaround fix makes ~170 times improvement on "new DateTimeZone()" > and as result visible improvement on some real-life apps (e.g Symfony demo > gets ~7% according to callgrind). > This is a huge difference. > > The fix was proposed more than a half year ago... > It would be great to include it into PHP-8.1 release. Such improvements are more than welcome, especially for such obvious patch. One could argue that the length of the data may change in the future but it can be increase then, or a macro can define it easily. It is late in the run to include it, but if RMs are OK, I would be all for applying it. The lib is bundled and whether the external repository applies it should not be relevant at this point (also no activity in 2 years there), or? Cheers, -- Pierre @pierrejoye | http://www.libgd.org