Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115866
MIME-Version: 1.0
References: <CAGKNXQE=F9PraKgOMTjP97DvhyFgKh=EMRoSAtEcZGGaNPTNWA@mail.gmail.com>
 <775dc98a-b3c5-d498-71f7-9f19ff891f29@telia.com> <CA+kxMuRBPUkcFTt_A=QjX-_xaE4UZKsx-9_Umz4jT6W7-E8djg@mail.gmail.com>
 <CAF+90c_4hzt6yiJyvPLRhFWTa5Fuyze5mG64mVG7oy0gZXnN7A@mail.gmail.com> <6127ded1.1c69fb81.6eaae.173cSMTPIN_ADDED_MISSING@mx.google.com>
In-Reply-To: <6127ded1.1c69fb81.6eaae.173cSMTPIN_ADDED_MISSING@mx.google.com>
Date: Thu, 26 Aug 2021 21:57:14 +0200
Message-ID: <CAF+90c8uRTkfpHjTrJjnvNX_tMKxhqHJuKNFxAm2taq7EVLtKw@mail.gmail.com>
To: Ben Ramsey <ramsey@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000e75f3305ca7bc613"
Subject: Re: [PHP-DEV] Re: 8.1 / Exception / Property Type / Backwards compatbility
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000e75f3305ca7bc613
Content-Type: text/plain; charset="UTF-8"

On Thu, Aug 26, 2021 at 8:34 PM Ben Ramsey <ramsey@php.net> wrote:

> Nikita Popov wrote on 8/26/21 09:57:
> > Right. I at least do not plan to address this issue. If you take a
> > protected property and publicly re-export it, then any compatibility
> issues
> > are on you.
>
> This does not appear to affect only cases where one is re-exporting a
> protected property as public.
>
> Exception protected properties without type hints:
>
> * PHP <= 8.0 - https://3v4l.org/GWmrk
> * PHP 8.1 - https://3v4l.org/GWmrk/rfc
>
>
> Exception protected properties with type hints:
>
> * PHP <= 8.0 - https://3v4l.org/UX1Pa
> * PHP 8.1 - https://3v4l.org/UX1Pa/rfc
>

These are not really meaningful examples, because you could simply not
redeclare the property at all and assign it in the constructor instead (or
preferably, let the parent constructor assign it). That's the normal way to
extend exceptions. What made the original case interesting is that the
property redeclaration isn't immediately redundant there, because it
changes visibility.

Regards,
Nikita

--000000000000e75f3305ca7bc613--