Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115865
To: Ben Ramsey <ramsey@php.net>, php internals <internals@lists.php.net>
References: <CAGKNXQE=F9PraKgOMTjP97DvhyFgKh=EMRoSAtEcZGGaNPTNWA@mail.gmail.com>
 <775dc98a-b3c5-d498-71f7-9f19ff891f29@telia.com>
 <CA+kxMuRBPUkcFTt_A=QjX-_xaE4UZKsx-9_Umz4jT6W7-E8djg@mail.gmail.com>
 <CAF+90c_4hzt6yiJyvPLRhFWTa5Fuyze5mG64mVG7oy0gZXnN7A@mail.gmail.com>
 <php.internals-115864@news.php.net>
Reply-To: =?UTF-8?Q?Bj=c3=b6rn_Larsson?= <bjorn.x.larsson@telia.com>
Message-ID: <e0aadb21-f2bd-b8c9-90b5-e420dd08d3b8@telia.com>
Date: Thu, 26 Aug 2021 21:46:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <php.internals-115864@news.php.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Re: 8.1 / Exception / Property Type /
 Backwardscompatbility
From: internals@lists.php.net ("Björn Larsson via internals")

Den 2021-08-26 kl. 20:34, skrev Ben Ramsey:
> Nikita Popov wrote on 8/26/21 09:57:
>> Right. I at least do not plan to address this issue. If you take a
>> protected property and publicly re-export it, then any compatibility issues
>> are on you.
> 
> This does not appear to affect only cases where one is re-exporting a
> protected property as public.
> 
> Exception protected properties without type hints:
> 
> * PHP <= 8.0 - https://3v4l.org/GWmrk
> * PHP 8.1 - https://3v4l.org/GWmrk/rfc
> 
> 
> Exception protected properties with type hints:
> 
> * PHP <= 8.0 - https://3v4l.org/UX1Pa
> * PHP 8.1 - https://3v4l.org/UX1Pa/rfc
> 
> Cheers,
> Ben
> 
So it looks like we have a bug here since the same code behaves
differently between 8.0 and 8.1.

I don't think it's obvoius that by adding a type hint we get
different behaviour for the "same" code in 8.0 vs 8.1.

The reason I brought this up is that in an Open source library
it's discussed how to solve this. Loading different versions of
the libray feels clunky.

r//Björn L