Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115859
MIME-Version: 1.0
References: <CAGKNXQE=F9PraKgOMTjP97DvhyFgKh=EMRoSAtEcZGGaNPTNWA@mail.gmail.com>
 <775dc98a-b3c5-d498-71f7-9f19ff891f29@telia.com>
In-Reply-To: <775dc98a-b3c5-d498-71f7-9f19ff891f29@telia.com>
Date: Thu, 26 Aug 2021 15:43:05 +0100
Message-ID: <CA+kxMuRBPUkcFTt_A=QjX-_xaE4UZKsx-9_Umz4jT6W7-E8djg@mail.gmail.com>
To: =?UTF-8?Q?Bj=C3=B6rn_Larsson?= <bjorn.x.larsson@telia.com>
Cc: Philip Hofstetter <phofstetter@sensational.ch>, php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: 8.1 / Exception / Property Type / Backwards compatbility
From: Danack@basereality.com (Dan Ackroyd)

On Thu, 26 Aug 2021 at 12:42, Bj=C3=B6rn Larsson via internals
<internals@lists.php.net> wrote:
>
> Den 2021-08-10 kl. 11:55, skrev Philip Hofstetter:
> > The following valid <=3D PHP 8.0 code that intends to make the $line pr=
operty
> > public  is a fatal error in 8.1
....
> >
> > For method return types, we have #[ReturnTypeWillChange], but for prope=
rty
> > types =F0=9F=A4=B7=E2=80=8D=E2=99=80=EF=B8=8F

> Hi,
>
> Has this been adressed / solved in some way and does it needs
> to be fixed?

My understanding is that the two scenarios are not the same and that
there isn't much enthusiasm for 'fixing' it.

For return types, the #[ReturnTypeWillChange] annotation is a
temporary work-around, and one that would be used by a lot of people.
It would only be used by a library until that library drops support
for older versions of PHP.

For the exception case, the way that (for legacy reasons) PHP supports
having a public property in a child class that "overwrites" (mostly)
the protected property in the parent class, is a pretty hinkey thing
to do, and so this is likely to only affect a small number of people.
It's not obvious to me how long a bridging annotation would need to
hang around for, and it's really not obvious what the exact details of
how it would work would be.

I'd suggest using a getter method, which would work on all relevant version=
s.

cheers
Dan
Ack