Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115856
MIME-Version: 1.0
References: <CAF+90c-jYwb9o9aAuv-VESF7kUpF1QHq=9o4kPF5JoToUnLrGQ@mail.gmail.com>
 <1AE70ED7-156F-4034-AD63-A3427C765DB7@gmail.com>
In-Reply-To: <1AE70ED7-156F-4034-AD63-A3427C765DB7@gmail.com>
Date: Thu, 26 Aug 2021 16:26:02 +0200
Message-ID: <CAF+90c-g_MOc3kCnem3Av79OeYzZtEL0-gUee+zT-GKH-sWfqg@mail.gmail.com>
To: Claude Pache <claude.pache@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000076735105ca772651"
Subject: Re: [PHP-DEV] Unwrap reference after foreach
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000076735105ca772651
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Aug 14, 2021 at 6:00 PM Claude Pache <claude.pache@gmail.com> wrote=
:

>
> Le 13 ao=C3=BBt 2021 =C3=A0 15:28, Nikita Popov <nikita.ppv@gmail.com> a =
=C3=A9crit :
>
> Hi internals,
>
> I'd like to address a common footgun when using foreach by reference:
> https://wiki.php.net/rfc/foreach_unwrap_ref
>
> This addresses the issue described in the big red box at
> https://www.php.net/manual/en/control-structures.foreach.php. While this
> is
> "not a bug" (as our bug tracker can regularly attest), it's rather
> unexpected, and we could easily avoid it...
>
> Regards,
> Nikita
>
>
> A case that should be mentioned in the RFC is destructuring:
>
> ```php
> foreach ($foo as [ $x, &$y ]) { /* .... */ }
> ```
> https://3v4l.org/A5Vi7
>
> I assume that the reference in `$y` would be unwrapped after the loop?
>

I clarified to the RFC to say that
a) unwrapping also occurs if the loop is left using break, continue, goto
etc.
b) unwrapping occurs for array destructuring targets under the same
limitation of "simple variables only". So yes, $y would be unwrapped in
your example.

Regards,
Nikita

--00000000000076735105ca772651--