Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115852
To: Philip Hofstetter <phofstetter@sensational.ch>,
 php internals <internals@lists.php.net>
References: <CAGKNXQE=F9PraKgOMTjP97DvhyFgKh=EMRoSAtEcZGGaNPTNWA@mail.gmail.com>
Reply-To: =?UTF-8?Q?Bj=c3=b6rn_Larsson?= <bjorn.x.larsson@telia.com>
Message-ID: <775dc98a-b3c5-d498-71f7-9f19ff891f29@telia.com>
Date: Thu, 26 Aug 2021 13:42:48 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <CAGKNXQE=F9PraKgOMTjP97DvhyFgKh=EMRoSAtEcZGGaNPTNWA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
Subject: Re: 8.1 / Exception / Property Type / Backwards compatbility
From: internals@lists.php.net ("Björn Larsson via internals")

Den 2021-08-10 kl. 11:55, skrev Philip Hofstetter:
> Hello
> 
> The following valid <= PHP 8.0 code that intends to make the $line property
> public  is a fatal error in 8.1
> 
> class FooException extends Exception {
>      public $line;
> }
> 
> However, the fixed code for 8.1:
> 
> class FooException extends Exception {
>      public int $line;
> }
> 
> Is a fatal error in <= 8.0
> 
> Is there a way to create a class that makes the $line property public
> that’s compatible with all versions of PHP without requiring conditional
> declaration of the class?
> 
> For method return types, we have #[ReturnTypeWillChange], but for property
> types 🤷‍♀️
> 
> Philip
> 
Hi,

Has this been adressed / solved in some way and does it needs
to be fixed?

I mean we are approaching RC1.

r//Björn L