Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115846
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
In-Reply-To: <28f3b632-6a55-4338-e846-2df0b94ea925@rhsoft.net>
Date: Thu, 26 Aug 2021 03:24:39 -0400
Cc: PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <45A7F614-5568-4A4F-9502-C0807486250E@newclarity.net>
References: <CAF+90c9_qu=PiTS81J2mesPfJdz7n5nSi3qoLNLjhEGN-aTytA@mail.gmail.com>
 <df1992f6-fef0-8f62-95d3-dcbc4a5b86d1@gmail.com>
 <CAF+90c_o1eRxPdJBrOai0Vnmsc=-MYpaWq0wY9zNuL_Vc5jm8Q@mail.gmail.com>
 <763725c0-870b-e8c4-054b-1ea0481ef877@gmail.com>
 <CAPKYkKxN5LV9S7FK6WipV3U=06NWn3k7H2rgLko+Q+WJcHOQ5g@mail.gmail.com>
 <476A4FAA-ACEB-428C-A3E8-990464F9F98C@newclarity.net>
 <9bc86399-66d3-a6f3-f246-048be850369c@rhsoft.net>
 <B0D3ACA4-FE78-4E3E-9629-E7FB35E8D47A@newclarity.net>
 <28f3b632-6a55-4338-e846-2df0b94ea925@rhsoft.net>
To: "Reindl Harald (privat)" <harry@rhsoft.net>
Subject: Re: [PHP-DEV] [RFC] Deprecate dynamic properties
From: mike@newclarity.net (Mike Schinkel)

> On Aug 26, 2021, at 2:27 AM, Reindl Harald (privat) <harry@rhsoft.net> =
wrote:
> Am 26.08.21 um 00:59 schrieb Mike Schinkel:
>>> On Aug 25, 2021, at 6:41 PM, Reindl Harald (privat) =
<harry@rhsoft.net> wrote:
>>> Am 26.08.21 um 00:37 schrieb Mike Schinkel:
>>>> That said, I'd be really interested in seeing use-cases where =
having dynamic properties is essential to an architecture and where it =
could not be easily refactored.  I cannot envision any, but I am sure =
that I am just limited by the extent of my vision and so would like to =
know what those use-cases would be.
>>>=20
>>> public function __get(string $subclass)
>>> {
>>>  $include_file =3D =
"{$this->basedir}/modules/{$subclass}/api_{$subclass}.php";
>>>  $class_name =3D "cl_{$subclass}";
>>>  if(!include $include_file)
>>>  {
>>>   $this->misc->trigger_error("API-LOADER FAILED: '{$subclass}'");
>>>   }
>>>  $this->$subclass =3D new $class_name;
>>>  $this->$subclass->cl_api =3D $this;
>>>  return $this->$subclass;
>>> }
>> Easily refactored:
>> public function __get(string $subclass)
>> {
>>   if (isset($this->subclasses[$subclass])) {
>>     return $this->subclasses[$subclass];
>>   }
>>   $include_file =3D =
"{$this->basedir}/modules/{$subclass}/api_{$subclass}.php";
>>   $class_name =3D "cl_{$subclass}";
>>   if(!include $include_file)
>>   {
>>     $this->misc->trigger_error("API-LOADER FAILED: '{$subclass}'");
>>   }
>>   $this->subclasses[$subclass] =3D new $class_name;
>>   $this->subclasses[$subclass]->cl_api =3D $this;
>>   return $this->subclasses[$subclass];
>> }
>=20
> and now get is called every single time a property or method in the =
class-tree is called instead only at the first call
>=20
> means in the real world probably thousands of times for each website =
call - congratulations

https://3v4l.org/HAkhjW#v8.0.9

Total execution time for 5000 iterations for BadActor =3D 0.351906 =
milliseconds
Total execution time for 5000 iterations for GoodActor =3D 0.758886 =
milliseconds
Total time difference for 5000 iterations =3D 0.406981 milliseconds
Total time difference for 1 iteration =3D 1/12,286 millisecond

"Premature optimization is the root of all evil"=20
=E2=80=94 Sir Tony Hoare=20

-Mike