Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115814
To: Rowan Tommins <rowan.collins@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <CAF+90c9_qu=PiTS81J2mesPfJdz7n5nSi3qoLNLjhEGN-aTytA@mail.gmail.com>
 <df1992f6-fef0-8f62-95d3-dcbc4a5b86d1@gmail.com>
 <CAF+90c_o1eRxPdJBrOai0Vnmsc=-MYpaWq0wY9zNuL_Vc5jm8Q@mail.gmail.com>
 <763725c0-870b-e8c4-054b-1ea0481ef877@gmail.com>
Message-ID: <23055540-3829-6952-5c92-588eb90b699a@processus.org>
Date: Wed, 25 Aug 2021 16:08:04 +0200
MIME-Version: 1.0
In-Reply-To: <763725c0-870b-e8c4-054b-1ea0481ef877@gmail.com>
Content-Type: multipart/alternative;
 boundary="------------160A1A2AFA6C7281F482794B"
Content-Language: en-US
Subject: Re: [PHP-DEV] [RFC] Deprecate dynamic properties
From: pierre-php@processus.org (Pierre)

--------------160A1A2AFA6C7281F482794B
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Le 25/08/2021 à 15:51, Rowan Tommins a écrit :
> On 25/08/2021 13:45, Nikita Popov wrote:
>
>> We obviously need to keep support for dynamic properties on stdClass, 
>> and if we do so, I would expect that to apply to subclasses as well.
>
> Does that actually follow, though? Right now, there is no advantage to 
> extending stdClass, so no reason to expect existing code to do so, and 
> no reason for people doing so to expect it to affect behaviour.
>
>
>> Second, I consider "extends stdClass" to be something of a last-ditch 
>> option. If you encounter a dynamic property deprecation warning, you 
>> should generally resolve it in some other way, and only fall back to 
>> "extends stdClass" as the final option.
>
>
> That's a reasonable argument in terms of the multiple inheritance case.
>
> My concern about the name remains though: people already do get 
> confused by the name "stdClass", because it's not in any way 
> "standard", and tells you nothing about what it does.
>
> Reading "class Foo extends stdClass" gives the reader no clues what 
> magic behaviour is being inherited; "class Foo extends DynamicObject" 
> would be much more clear. Similarly, "$foo = new DynamicObject; 
> $foo->bar = 42;" is clearer than "$foo = new stdClass; $foo->bar = 42;"
>
> Regards,
>
Hello,

And why not adding an extra keyword, such as:

```
<?php
dynamic class Foo { } // Dynamic allowed
class Bar {} // Dynamic disallowed
?>
```

Regards,

--

Pierre


--------------160A1A2AFA6C7281F482794B--