Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115809
To: internals@lists.php.net
References: <CAF+90c9_qu=PiTS81J2mesPfJdz7n5nSi3qoLNLjhEGN-aTytA@mail.gmail.com>
 <df1992f6-fef0-8f62-95d3-dcbc4a5b86d1@gmail.com>
Message-ID: <20c3c14b-8132-1114-641c-d07e3cb54b4b@gmx.net>
Date: Wed, 25 Aug 2021 14:35:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <df1992f6-fef0-8f62-95d3-dcbc4a5b86d1@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
Subject: Re: [PHP-DEV] [RFC] Deprecate dynamic properties
From: a.leathley@gmx.net (Andreas Leathley)

On 25.08.21 12:45, Rowan Tommins wrote:
> * Adding a parent to an existing class isn't always possible, if it
> already inherits from something else. Perhaps the behaviour could also
> be available as a trait, which defined stub __get and __set methods,
> allowing for the replacement of the internal implementation as you've
> described?
>
Couldn't this be easily done in userland with the ArrayLikeObject (an
example in the RFC) or something similar, just done as a trait? Maybe
having an example trait implementation that basically "imitates"
stdClass in terms of dynamic properties would be helpful to show in the
RFC, to highlight a possible resolution path for legacy code with this
problem. This could be an example implementation:

trait DynamicPropertiesTrait
{
 =C2=A0=C2=A0=C2=A0 private array $dynamicProperties =3D [];
 =C2=A0=C2=A0=C2=A0 public function &__get(string $name): mixed { return
$this->dynamicProperties[$name]; }
 =C2=A0=C2=A0=C2=A0 public function __isset(string $name): bool { return
isset($this->dynamicProperties[$name]); }
 =C2=A0=C2=A0=C2=A0 public function __set(string $name, mixed $value): voi=
d {
$this->dynamicProperties[$name] =3D $value; }
 =C2=A0=C2=A0=C2=A0 public function __unset(string $name): void {
unset($this->dynamicProperties[$name]); }
}