Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115762
MIME-Version: 1.0
References: <42b262eb-0d9b-8feb-cc3d-da3e36e14d1e@mabe.berlin>
 <CAF+90c81nB7SzRYBQtQZAuDKbHFToa7Jc3LVGNgrxB4uGtTh9g@mail.gmail.com> <5f05e230-4f19-aa5b-73c4-78dd52e95764@mabe.berlin>
In-Reply-To: <5f05e230-4f19-aa5b-73c4-78dd52e95764@mabe.berlin>
Date: Wed, 18 Aug 2021 14:28:35 +0200
Message-ID: <CAC5V6ggbSk491Org2DpVusB8nbkKxJkPmZ_DXCGsUubS3nSefQ@mail.gmail.com>
To: Marc <marc@mabe.berlin>
Cc: Nikita Popov <nikita.ppv@gmail.com>, internals@lists.php.net
Content-Type: multipart/alternative; boundary="00000000000057531c05c9d493b9"
Subject: Re: [PHP-DEV] readonly properties
From: guilliam.xavier@gmail.com (Guilliam Xavier)

--00000000000057531c05c9d493b9
Content-Type: text/plain; charset="UTF-8"

>
> >> 2. DateInterval->days
> >>
> >> $interval = (new DateTime())->diff(new DateTime());
> >> var_dump($interval->days); // 0
> >> $refl = (new ReflectionObject($interval))->getProperty('days');
> >> var_dump($refl->isReadOnly()); // false
> >> var_dump($refl->isPublic()); // true
> >> $interval->days = 2;
> >> var_dump($interval->days);  // 0
> >>
> > The DateInterval properties are currently implemented as getters/setters
> on
> > some internal state. Some of those are getter-only, but probably not
> fully
> > immutable.
>
> I was referring to the property "days" only as this is a non writable
> value generated on "DateTime->diff".
>
> As you can see in the snipped it doesn't allow to modify days but it
> also doesn't fail which seems wrong to me.
>
> I don't have much knowledge about internals but would it be possible to
> define "public readonly int|false $days" not using getters/setters and
> keep all other properties as it?
>

Hi,

FWIW, I too agree that [$interval->days, $interval->days = 2,
$interval->days] giving [0, 2, 0] without any warning (or
https://3v4l.org/h8Cju for a variation) seems wrong.

Regards,

-- 
Guilliam Xavier

--00000000000057531c05c9d493b9--