Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:115761 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 26759 invoked from network); 18 Aug 2021 11:29:17 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 18 Aug 2021 11:29:17 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id E1B781804DB for ; Wed, 18 Aug 2021 05:01:45 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_05,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 18 Aug 2021 05:01:45 -0700 (PDT) Received: by mail-lf1-f54.google.com with SMTP id w20so4099873lfu.7 for ; Wed, 18 Aug 2021 05:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gt5WHvhnDExbNg4eMIOq2U7XDQul0ftVs/dBNJEOItw=; b=XROna3RCSyF0I+ildRk5u8oXz0rtPTRvo0NO0b1jxXpiwQjnOfGS9hdByUTsYSx8oj eWFOQO9Lfq2G33Fe3LDBaYekYbGefVPt992xUaJvK62O0yPMogG63yKhveM6qKJ8IkFd 08mABEk8iKT8Hw/iR+fEVaPVqI26AjuOAoZFSdaMOEWE3fPUSlmEQDlKeVTg+PH2Rmqx DKE6tvUpJZ26ThmbMgQ4NRJEH4XlCrbftcJT3EWm7Sj6qw1xKZ89bZMflDhzfWNKkg9w XknknQBgjXhbbvcc6TuksTP8m7nzFqGw+ANMctm9rt1H6qrWb6vvBL/DNR4Cg74tbCXj ZiJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gt5WHvhnDExbNg4eMIOq2U7XDQul0ftVs/dBNJEOItw=; b=ZsyeiYQpTBCga6idTkQ9ihZEndv43X8RBkTb4FM0kTBCsPgwvxClk4ggpJuGK2SCrR FOa2T0P0cQ050wgupHKTJAEcjL8i8VUxNd8Iqn3ownAIQhVBVRq4lEbtiXkOTp6GvlYJ cewD5ReZcQJEFXoHnWDGJLvlVO0bdqf1vnh1FHuNvVyX8BOBn8I+EvaCCb/dZlMWTdbM QMzTNcXbXiTZaakXoreA87iYd1Vit6mwP/5vyMuQHhV555UZVlDHIg9t0EoPKQuQzili 3q7YSVeoKl0a2DRXx6aAIRihcjLnP8/VLOvPqlGohyk1c1pUED4TqVYAQMd8BPpB8mBL cNlw== X-Gm-Message-State: AOAM53075MBSNfQ2gC1FB69Edw1qgur3BOtUT9a1Gb+LBwz39Jm9S/PZ 7Erru8YBpZFsNCuMEsTIapCP4+2T9xq7Hs1MqQ== X-Google-Smtp-Source: ABdhPJynoD/inii8+p3QfNMpAkK27GBlh1myJgEdjzECNByM4F7fvpM5mp6U2ZyAe3AKf1/KrIlOS21ZOv/crm732y8= X-Received: by 2002:a05:6512:1144:: with SMTP id m4mr6010820lfg.267.1629288103353; Wed, 18 Aug 2021 05:01:43 -0700 (PDT) MIME-Version: 1.0 References: <7DA18959-3463-4AAE-ABE3-B9330FEE83D2@gmail.com> In-Reply-To: Date: Wed, 18 Aug 2021 14:01:33 +0200 Message-ID: To: Kamil Tekiela Cc: Rowan Tommins , PHP internals Content-Type: multipart/alternative; boundary="000000000000a3200105c9d432e3" Subject: Re: [PHP-DEV] Re: [RFC] Add parse_query_string as an alternative to parse_str From: guilliam.xavier@gmail.com (Guilliam Xavier) --000000000000a3200105c9d432e3 Content-Type: text/plain; charset="UTF-8" On Fri, Aug 6, 2021 at 9:43 PM Kamil Tekiela wrote: > Hi Internals, > > Thanks for all the feedback. I have changed the name to http_parse_query as > it looks like more people prefer that name. I have also updated > https://wiki.php.net/rfc/parse_str_alternative for 8.2 (sorry for the > confusion) and I added open points. > I hear two concerns currently about this RFC. Please note that my intention > was to provide a simple drop-in replacement. However, I agree that there is > a lot of room for improvement in this area, so I highly appreciate your > comments on how we can best tackle these open points. > I will not open this RFC for voting any time soon, as I want to let the > conversation run through to see what other options/concerns people have. > Please feel free to share your comments on what you think is the right path > to improve this functionality in PHP. > > Regards, > Kamil > Hi, thanks for the RFC. I agree with Rowan in https://externals.io/message/115642 that http_parse_query() should "mirror http_build_query() as closely as possible", notably: - have a similar signature (except for the first parameter `array|object $data` becoming `string $query` and the return type `string` becoming `array`, of course); - do not do name mangling (and for your question "what should happen to mismatched square brackets?": not sure without an example, but I would say "just keep them as is"). Best regards, -- Guilliam Xavier --000000000000a3200105c9d432e3--