Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:11567 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 74953 invoked by uid 1010); 26 Jul 2004 07:58:07 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 74822 invoked from network); 26 Jul 2004 07:58:07 -0000 Received: from unknown (HELO tellyd2.de) (217.160.72.104) by pb1.pair.com with SMTP; 26 Jul 2004 07:58:07 -0000 Received: from 27.0.0.10.in-addr.arpa (pD9E93FD6.dip.t-dialin.net [217.233.63.214]) by tellyd2.de (Postfix) with ESMTP id 205C43C152; Mon, 26 Jul 2004 09:58:06 +0200 (CEST) Date: Mon, 26 Jul 2004 09:58:01 +0200 (CEST) X-X-Sender: sas@localhost To: Antony Dovgal Cc: php-dev In-Reply-To: <20040726104937.5e5f12dc.tony2001@phpclub.net> Message-ID: References: <20040726104937.5e5f12dc.tony2001@phpclub.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: Re: [PHP-DEV] [PATCH] bug #29336 From: sascha@schumann.cx (Sascha Schumann) On Mon, 26 Jul 2004, Antony Dovgal wrote: > Hi all! > > Plz, take a look at bug #29336 ( http://bugs.php.net/29336 for lazy > ones =)). > HEAD segfaults on session_start() after empty_string -> > STR_EMPTY_ALLOC() change. This happens because SID constant gets > initialized with "" string instead of STR_EMPTY_ALLOC(). > > The patch: http://tony2004.phpclub.net/dev/tmp/session.diff seems to > be the solution. The second part regarding session.c is ok. > Another one issue, that is being fixed by this patch, is false memory > leak message ("Freeing 0 bytes blah-blah"), similar to this: > http://lists.php.net/php.zend-engine.cvs/2796 issue. The read process should just be skipped, if the file has zero length. I'll look into this later this day. - Sascha