Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115646
To: Rowan Tommins <rowan.collins@gmail.com>, internals@lists.php.net
References: <CAOV5rgZSeSS89kV8jgt+Deyu9vHF-n5JQ+X9ab+ZVjjUCWeRPQ@mail.gmail.com>
 <CAJvSBVNFet1_HerapBPsCz-Q_MyyWnc84jvfmWGgyPY188OG_Q@mail.gmail.com>
 <CAJmy8YFC2L1vX=grQhXtS0_sV28-k6rMJT0z96mYgU1J+_Z25g@mail.gmail.com>
 <CAGBsUrej70Hu-+1q7A_ZsUci4JmcPO-=7f_QVeQN=d5in4_rGQ@mail.gmail.com>
 <70ae3208-250b-5d47-28d7-282d7bf44ed7@gmail.com>
Message-ID: <ea2f090f-59b8-0f44-ba0b-a685f1cbc4fc@gmx.de>
Date: Fri, 6 Aug 2021 17:38:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <70ae3208-250b-5d47-28d7-282d7bf44ed7@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] Add parse_query_string as an alternative
 toparse_str
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 06.08.2021 at 15:20, Rowan Tommins wrote:

> On 06/08/2021 12:12, Kamil Tekiela wrote:
>
>> Perhaps, instead of adjusting this behaviour only for the new
>> function, we
>> could remove this behaviour as a whole, given that it is a remainder
>> of the
>> long-forgotten register globals? I don't see any use for it anymore
>
> Changing behaviour like this is tricky, because even if it's not that
> useful, it is consistent, so code to process a query string of
> "?foo.bar=3D42" will be looking at $_GET['foo_bar'] not $_GET['foo.bar']=
.
> If we "fix" the name mangling, that code will break, and not necessarily
> in a very obvious way.
>
> Note that there are other parts of the request which get mangled in
> similar ways, such as when HTTP headers are translated into CGI
> environment variables. The solution in that case is to ignore the CGI
> vars and use a function like getallheaders(), so having a non-mangling
> http_parse_query() doesn't feel out of place.

Right.  *If* we want to change this name mangling, we should change it
everywhere, and that certainly needs an own RFC and ideally some kind of
deprecation/change notice.

=2D-
Christoph M. Becker