Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115625
MIME-Version: 1.0
References: <CAJSGLVMX79-6_NRJ9zfJOhivVrTrjtxcQxT9A_XR6BwPVgpodA@mail.gmail.com>
 <d7973065-b6a9-fdf1-0864-7a6f2ed6216f@alec.pl> <CAJSGLVMobxZzDnK14kzzJXFoWzNECPMmRZnrSRwrsdXAXuOsLg@mail.gmail.com>
 <ea101033-6c1b-3769-de6d-33634eddfeaf@alec.pl> <CAJmy8YExyWm6xr1k5J2ojFSTaJ=akyfQUCYU+EOi+eLOhsppCw@mail.gmail.com>
In-Reply-To: <CAJmy8YExyWm6xr1k5J2ojFSTaJ=akyfQUCYU+EOi+eLOhsppCw@mail.gmail.com>
Date: Tue, 3 Aug 2021 09:47:10 -0500
Message-ID: <CAESVnVpW9pa-yKEpENF3i_vi4U+_u=AVdYO4G48Ct9qLCkRcRQ@mail.gmail.com>
To: Hans Henrik Bergan <divinity76@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000005f50b905c8a8c358"
Subject: Re: [PHP-DEV] [RFC] Under Discussion: Default User-Agent for cURL
From: pollita@php.net (Sara Golemon)

--0000000000005f50b905c8a8c358
Content-Type: text/plain; charset="UTF-8"

On Tue, Aug 3, 2021 at 4:45 AM Hans Henrik Bergan <divinity76@gmail.com>
wrote:

> fwiw i think no self-respecting codebase is depending on an ini-setting
> being correct for the ua in cases where the ua is actually important, so
> the breakage should be minimal.
>
>
In my mind, this is either an argument in favor of either NOT adding a new
INI setting (rather applying the existing user_agent setting to curl), or
doing nothing at all.  Code using curl already knows how to call the
precisely ONE line required to set a user agent, or more likely uses a
wrapper which simplifies cURL's archaic interface, in which case it's that
proxy which should be setting any default UA, not PHP.

And on the subject of PHP_INI_ALL/PERDIR/SYSTEM.  The answer is ALL.
PERDIR and SYSTEM exist either for technical limits (something gets
allocated and has to live across requests), or security limiters.  The
former certainly doesn't apply, and the latter wouldn't achieve anything
since the UA can always be set explicitly on any curl handle.   PHP_INI_ALL
is the only setting which makes sense if we add an additional configuration
(which I don't think we should).

-Sara

--0000000000005f50b905c8a8c358--