Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:11562 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 46556 invoked by uid 1010); 26 Jul 2004 06:48:41 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 46525 invoked from network); 26 Jul 2004 06:48:40 -0000 Received: from unknown (HELO is.magroup.ru) (213.33.179.242) by pb1.pair.com with SMTP; 26 Jul 2004 06:48:40 -0000 Received: from grp-dovgal.media-arts.ru ([192.168.3.226]) by is.magroup.ru with Microsoft SMTPSVC(5.0.2195.6713); Mon, 26 Jul 2004 10:49:37 +0400 Date: Mon, 26 Jul 2004 10:49:37 +0400 To: php-dev Message-ID: <20040726104937.5e5f12dc.tony2001@phpclub.net> X-Mailer: Sylpheed version 0.9.12cvs1 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 26 Jul 2004 06:49:37.0600 (UTC) FILETIME=[B7D86400:01C472DC] Subject: [PATCH] bug #29336 From: tony2001@phpclub.net (Antony Dovgal) Hi all! Plz, take a look at bug #29336 ( http://bugs.php.net/29336 for lazy ones =)). HEAD segfaults on session_start() after empty_string -> STR_EMPTY_ALLOC() change. This happens because SID constant gets initialized with "" string instead of STR_EMPTY_ALLOC(). The patch: http://tony2004.phpclub.net/dev/tmp/session.diff seems to be the solution. Another one issue, that is being fixed by this patch, is false memory leak message ("Freeing 0 bytes blah-blah"), similar to this: http://lists.php.net/php.zend-engine.cvs/2796 issue. Is there any comments/objections against the patch? --- WBR, Antony Dovgal aka tony2001 tony2001@phpclub.net || antony@dovgal.com