Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115618
Message-ID: <0B7E886D-C78B-4001-9228-27AB25CEA18A@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_1E82198F-F8B9-45BE-B6E0-E33E86E36D1E"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
Date: Sun, 1 Aug 2021 15:11:33 +0300
In-Reply-To: <CAGgaK7Keq9PsfWZ57+06yQeR8qq9vORagtd4SCrq1oJH9ROcWw@mail.gmail.com>
Cc: Internals <internals@lists.php.net>
To: Max Semenik <maxsem.wiki@gmail.com>
References: <22EF92EC-C5A3-498E-9EFD-DE2B5B204BB7@gmail.com>
 <CAGgaK7Keq9PsfWZ57+06yQeR8qq9vORagtd4SCrq1oJH9ROcWw@mail.gmail.com>
Subject: Re: [PHP-DEV] RFC: autoconst
From: free.smilesrg@gmail.com (Serhii Smirnov)

--Apple-Mail=_1E82198F-F8B9-45BE-B6E0-E33E86E36D1E
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

I am surprised that you called this proposal makes code less readable. =
Which code is more readable:

const SOME_LONG_NAMED_CONSTATN_FROM_ENVIRONMENT =3D =
'SOME_LONG_NAMED_COSNTATN_FROM_ENVIRONMENT';
or=20
autoconst SOME_LONG_NAMED_CONSTATN_FROM_ENVIRONMENT;
?

Also, could you see a typo error in the classic const definition?

> 1 =D0=B0=D0=B2=D0=B3. 2021 =D0=B3., =D0=B2 15:00, Max Semenik =
<maxsem.wiki@gmail.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0)=
:
>=20
> =D0=B2=D1=81, 1 =D0=B0=D0=B2=D0=B3. 2021 =D0=B3., 14:22 Serhii Smirnov =
<free.smilesrg@gmail.com <mailto:free.smilesrg@gmail.com>>:
> instead of defining constants like:
> const FOO =3D 'FOO';
>=20
> they could be defined like:
> autoconst FOO; // defines a constant FOO with the value 'FOO'
>=20
> Sorry, but I'm not a fan of this proposal. Features should not be =
aiming at minor savings of keystrokes at the expense of readability and =
maintainability. Remember, we write code once but afterwards it might =
end up being read hundreds of times. This proposal makes code less =
readable, and unintuitively works differently from enums where cases =
without explicit values don't default to anything.
>=20
> Also, modifiers could be useful:
> autoconst uppercase foo; // defines a constant foo with value 'FOO'
> autoconst lowercase FOO; // defines a constant FOO with value 'foo';
>=20
> and maybe:
> autoconst camelcase FOO_BAR; // defines a constant FOO_BAR with value =
'fooBar'
> autoconst snakecase fooBar; // defines a constant fooBar with value =
'foo_bar'
>=20
> This one saves even fewer keystrokes and harms maintainability even =
more: imagine you're debugging your program and you've dumped some =
value. You see "MyConstant". Now you search the code for the source of =
that value but find nothing because instead of MyConstant there's only =
MY_CONSTANT.


--Apple-Mail=_1E82198F-F8B9-45BE-B6E0-E33E86E36D1E--