Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115447
MIME-Version: 1.0
References: <CAM0CcxjJYYRrdzNjm285OQ6zDS8J7tqi0kLBeTGAP-2JXyqrDw@mail.gmail.com>
 <CA+hqhpeWACWYp=VNj0=oWkpPa++uiRF+=VmN34ZVBUu1dQOXPw@mail.gmail.com> <E2359773-7E55-4A87-9136-D43AA3A0E52F@newclarity.net>
In-Reply-To: <E2359773-7E55-4A87-9136-D43AA3A0E52F@newclarity.net>
Date: Sat, 17 Jul 2021 08:40:27 +0300
Message-ID: <CAM0Ccxij4xLPu4Mcd7-XPA92t5H=-PeOqUhzMsF3=APTRiB=PQ@mail.gmail.com>
To: Mike Schinkel <mike@newclarity.net>
Cc: Bruce Weirdan <weirdan@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000e3d5b805c74b24ee"
Subject: Re: [PHP-DEV] Readonly properties - immutability by default
From: zsidelnik@gmail.com (Eugene Sidelnyk)

--000000000000e3d5b805c74b24ee
Content-Type: text/plain; charset="UTF-8"

> Having a "readonly" class where the properties are read-only by default
makes sense to me, but maybe the better way to do it is with an attribute?

We already have such an attribute provided. It is called [`#[Immutable]`](
https://blog.jetbrains.com/phpstorm/2020/10/phpstorm-2020-3-eap-4/#immutable
).
If the intention is to add some logic for attributes, then unlikely it is
going to be accepted because attributes by definition are meta-data. It
doesn't add any logic for program.


On Sat, Jul 17, 2021 at 12:09 AM Mike Schinkel <mike@newclarity.net> wrote:

> > On Jul 16, 2021, at 6:12 AM, Bruce Weirdan <weirdan@gmail.com> wrote:
> >
> > On Fri, Jul 16, 2021 at 9:45 AM Eugene Sidelnyk <zsidelnik@gmail.com>
> wrote:
> >
> >> Readonly properties are really useful for DDD, where everything is
> going to
> >> be immutable. It promotes best practices. However for people to use it,
> >> syntax should be concise and brief.
> >
> > If every property of the class is readonly it would probably be better
> > to declare that with a class modifier.
> >
> > E.g.
> >
> > ```php
> > readonly class Entity {
> >    public int $count;
> >    public string $data;
> > }
> > ```
>
> Having a "readonly" class where the properties are read-only by default
> makes sense to me, but maybe the better way to do it is with an attribute?
>
> #[Readonly]
> class Entity {
>    public int $count;
>    public string $data;
> }
>
> OTOH, that would be inconsistent with using `readonly` as a keyword for
> properties.
>
> -Mike
> P.S. Maybe readonly properties should be implemented with an attribute
> instead of a keyword?  But then that would be opening a can of worms...
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--000000000000e3d5b805c74b24ee--