Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115420
To: "internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: Changing method naming in FFI Type Reflection API from
 Arg->Parameter, etc
Thread-Index: AQHXd+yHhG4u7tRODEilHBKBJW2Z/A==
Date: Tue, 13 Jul 2021 13:51:28 +0000
Message-ID:
 <DM6PR07MB66185254B3E799F927E945EBF9149@DM6PR07MB6618.namprd07.prod.outlook.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 78aabfa3-f255-47c8-20c2-08d946055085
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 13:51:28.7949
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM11HT157
Subject: Changing method naming in FFI Type Reflection API from
 Arg->Parameter, etc
From: tysonandre775@hotmail.com (tyson andre)

Hi internals,=0A=
=0A=
The FFI Type Reflection API mentioned in https://externals.io/message/11533=
6 was recently added=0A=
=0A=
My opinion is that that they should be renamed to use the same naming schem=
e that PHP's Reflection extension is already using.=0A=
Having different ways of naming very similar concepts (different from https=
://www.php.net/reflectionfunctionabstract) would make the language harder t=
o remember.=0A=
I'd brought that up in https://github.com/php/php-src/pull/7217#pullrequest=
review-700990479 with no response=0A=
=0A=
What do others think about the name? I was considering holding a short vote=
=0A=
(on getReturnType, getParameterCount, getParameterType) before the feature =
freeze if there was interest=0A=
=0A=
In particular,=0A=
=0A=
- FFI\CData->getFuncReturnType should be changed to getReturnType - only fu=
nctions have return types=0A=
=0A=
  This is consistent with https://www.php.net/reflectionfunctionabstract =
=0A=
- I believe Arg should be renamed to Parameter and Func should be removed f=
rom names where redundant.=0A=
  E.g. getFuncArgCount should be renamed to getParameterCount (getFuncArgTy=
pe should be renamed getParameterType) - only functions have parameters,=0A=
  and PHP is already already using "Parameter" instead of "Argument" for re=
flection on types elsewhere.=0A=
=0A=
  Parameter is used to refer to the function declarations (AST_PARAM intern=
ally in the AST, ReflectionFunctionAbstract->getParameters(), etc.)=0A=
  Argument is used to refer to expressions passed to the functions by the c=
aller (ArgumentCountError, etc.)=0A=
=0A=
  Other languages use similar definitions, e.g. https://developer.mozilla.o=
rg/en-US/docs/Glossary/Parameter=0A=
- The discussion over where FFI arrays should support Countable::count (and=
 non-arrays should throw) might be contentious so I'd rather keep getArrayL=
ength=0A=
=0A=
Thanks,=0A=
Tyson=