Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:115396 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 84667 invoked from network); 12 Jul 2021 07:28:40 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 12 Jul 2021 07:28:40 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 4AA43180089 for ; Mon, 12 Jul 2021 00:51:52 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 12 Jul 2021 00:51:51 -0700 (PDT) Received: by mail-lf1-f44.google.com with SMTP id q16so5329710lfa.5 for ; Mon, 12 Jul 2021 00:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=chv3c3b5UoCO8Hq7OZRsCcx9WbnSyN4N2fy4cAa1wPU=; b=qwVN7Tm9PaOsZrS+PZoEC+rcfLTr6MdaAZ2X9DvF6AQiMsu4yVKmASqwjKghCJXVFJ Jx7QFyEHiNch5BD61PYzvfKtUZ5MJFtX7EywLzGn6FLs+wr2yHsYU1tJi0PL9t79YcfJ 0mgkKieO9ESEGkEUxpGU0zF7gOR8hZDWJ4arhm/iXsjyigaa3sJ1XyMorjA9eTFHymxj MxxJp5t2Pz9HiPF7Tglwhx5LbWvdOa0adh63/oCqpciFWTPoSIAvsqMjPBktiBIEK0HS FlXndTfrbWMYXGpWTFebWQpe3YYVlwsDeQRsC1lRHiID14x+O8RgGHdK9SdJGRV7gWSW NUVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=chv3c3b5UoCO8Hq7OZRsCcx9WbnSyN4N2fy4cAa1wPU=; b=oy2HE1LovkUTucVI4ozHhFQZFcfbDNXAl76WEnkMklDVOry1yA0OBxkkzQZLOBgo6D /E2AIdjmtyLId1AXcKF/LQmN9IRW58Q63tnryrsVs4C6goMLScFv24uWe815ImMHXt1N snT7aKMme0LsRiZmuw1ZV17PxeKvif4MHILnf0IFENYNXTxOB5iRY7uRkOYtOYZztW/D ryUJ4tAJvPrxgrsqWDAg2w8K1P0HFufEnTKPoNxcOeG/ryZBUOGJLRcoT93MTaedNZdU /vhoMuig+hgSs18+polRk6pCTu/qGwp1mokV5XhWr3WJeb2aCiHXP0l6Sup9VYQNKn6M x9bg== X-Gm-Message-State: AOAM533M6TNPeQsCHzmYKmzqIdIf1CVSFL83mtpDCBr2bn3tGvv2yvpj GDWesTIuepqXHiB1E1oJFPIrFLt/0mEfL9YGxu7/+6m4OLk= X-Google-Smtp-Source: ABdhPJwS6zfZet0awEUqqLQRpQjWJl1QQdxOty7UpUV4RKUdHeZSzUiNflqQKAVvtqN8DMdBynlAumsUyAXeH3lhLYs= X-Received: by 2002:a19:7d05:: with SMTP id y5mr39250593lfc.159.1626076309387; Mon, 12 Jul 2021 00:51:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Mon, 12 Jul 2021 09:51:33 +0200 Message-ID: To: Pierre Cc: PHP internals , Patrick ALLAERT Content-Type: multipart/alternative; boundary="000000000000cc7ccc05c6e864f5" Subject: Re: [PHP-DEV] Fake Closure Comparison From: nikita.ppv@gmail.com (Nikita Popov) --000000000000cc7ccc05c6e864f5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jul 9, 2021 at 12:08 PM Pierre wrote: > Le 09/07/2021 =C3=A0 10:45, Joe Watkins a =C3=A9crit : > > Morning internals, > > > > While discussing some of the details of the first class callable RFC, i= t > > became apparent that fake closures (created by Closure::fromCallable) a= re > > not currently comparable in a useful way. > > > > Although this is not directly related to the first class callable > feature, > > it's likely that the proliferation of this kind of code will follow, so > now > > seems like a good time to fix the problem. > > > > https://github.com/php/php-src/pull/7223 > > > > Any objections to merging that in master ? > > > > Cheers > > Joe > > I don't see where I would actually compare callables, and I'm not an > engine maintainer, but from my point of view, this patch makes sense. > I'm also not sure where this would be actually useful (though I'm okay with including it, as the functionality itself seems sensible). As Patrick Allaert suggested this, maybe he can comment on some use cases. Regards, Nikita --000000000000cc7ccc05c6e864f5--