Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115376
MIME-Version: 1.0
References: <CAOwTYAsfc7kefcn8CW22p7bViOMoDxhmkJO35B3UhZiuSHYfzA@mail.gmail.com>
In-Reply-To: <CAOwTYAsfc7kefcn8CW22p7bViOMoDxhmkJO35B3UhZiuSHYfzA@mail.gmail.com>
Date: Fri, 9 Jul 2021 11:51:31 +0200
Message-ID: <CAF+90c-KXbu5e6=4iWGvix4Xxumu1YpafXBL82qoYLvpz5Meuw@mail.gmail.com>
To: Joe Watkins <krakjoe@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000052dd0d05c6adb8d0"
Subject: Re: [PHP-DEV] Fake Closure Comparison
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000052dd0d05c6adb8d0
Content-Type: text/plain; charset="UTF-8"

On Fri, Jul 9, 2021 at 10:45 AM Joe Watkins <krakjoe@php.net> wrote:

> Morning internals,
>
> While discussing some of the details of the first class callable RFC, it
> became apparent that fake closures (created by Closure::fromCallable) are
> not currently comparable in a useful way.
>
> Although this is not directly related to the first class callable feature,
> it's likely that the proliferation of this kind of code will follow, so now
> seems like a good time to fix the problem.
>
> https://github.com/php/php-src/pull/7223
>
> Any objections to merging that in master ?
>

To clarify: What this implements is that

$strlen1 = Closure::fromCallable('strlen');
$strlen2 = Closure::fromCallable('strlen');
var_dump($strlen1 == $strlen2);
// bool(true) with this patch, previously bool(false)

The same would also apply to the first-class callable syntax, i.e. after
this patch strlen(...) == strlen(...) would return true.

Regards,
Nikita

--00000000000052dd0d05c6adb8d0--