Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:115373 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 25969 invoked from network); 8 Jul 2021 22:01:33 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 8 Jul 2021 22:01:33 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 792AD1804B0 for ; Thu, 8 Jul 2021 15:23:54 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Thu, 8 Jul 2021 15:23:53 -0700 (PDT) Received: by mail-pl1-f180.google.com with SMTP id h1so3980933plf.6 for ; Thu, 08 Jul 2021 15:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oo1wKtZoRgljqA4sjhpq3azjEglWrwG6WippSzFWrJM=; b=T8cRG2eAj9pb5BEmq25Jqb23C+ozc7wQqgpD4MNse/IpL0DEbti+4vVKTXkyFE2wPx vtAcC5RpST3x4VQMbn0vSVlA4HpOzSxtXgG/k0mVkIIwQmFYnUXX4QTyqp88CgboGHpo u3fKnQ9aBOLsZZro8RBGE73dCtiOztN2Rq2uWZR826lTjwWacZHDmWAiPhGSmWPal4dj BVMZ89OoooNFUqwlJr9Isi9wKtIWJgtLTVESamT30VLK0J9HoZYlIwUFqL9rOhPIFH2r gGn/u9y9XeD6bfm2UXQscDWw95qxifMnY66aXYz4xifGfWtoc63LOQ1bCunCJFEyZl5y rCjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oo1wKtZoRgljqA4sjhpq3azjEglWrwG6WippSzFWrJM=; b=kvXmpo0y3HbXaQGrunMQd5VQ+66w3j4N3PRE3K/AZnHgKv8gWrcuPbIL0IlFeNd7eM 0zGZpOUdX0NGarm385t4f4rGuqZ+iLR5wrEa1Qdw3+pPeqYQ8SfoBnceW7Lis6Vd657G wZ67Cs7vQwJEQNMvGG5aNB7O0aWxBh6EIJ42vRLoKThH/CeO+dEmu/+J2+zuh9olADPE U78a3O15S9zMeosT2SbHnF1ZSw4zYt1oePnk8vM+mq/Pv27zfCeqaDhhwEfCTEUpD3B1 MMPUGq/ecLvkWQIk0BNG+BwEbnFb9ggqnZ39WuOgBtY1FNBfptq+mL5ABVgPGRwGgaB2 Xfag== X-Gm-Message-State: AOAM530uZQULEyyTyNBdx7+o/tFor/eAg81j3CBQ0iBGFsDaJ0G/qrIg kcKaGcFJpKmrzSLPeFkEwTzUhuR6/2NmBJO8tes= X-Google-Smtp-Source: ABdhPJwMpTnAgBUg1Qrj6s4fpi6TCf6oFQBwk8plXIlsmzY13kg6Rn90xaI0zv7O6j8Wc8fLMoKPZpdWZENYAfweqTU= X-Received: by 2002:a17:90a:9282:: with SMTP id n2mr34200540pjo.204.1625783032541; Thu, 08 Jul 2021 15:23:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Fri, 9 Jul 2021 00:23:41 +0200 Message-ID: To: Nikita Popov Cc: Craig Francis , PHP internals Content-Type: multipart/alternative; boundary="00000000000022f7f105c6a41c80" Subject: Re: [PHP-DEV] [RFC] [VOTE] is_literal From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=) --00000000000022f7f105c6a41c80 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Nikita, I performed a few other benchmarks in order to provide a little bit more insights into the performance aspect of the RFC. My latest measurement is using the same setup as the previous one, although I made a few smaller changes in the process (e.g. changing the order of the tests). So at the end, I got the following results: - Laravel demo app: +0.1% - Symfony demo app: +0.43% - bench.php: +0.4% - custom concat bench: +3.89% The results are comparing the "literals" branch with the commit in master on which Joe's work is based. As far as I remember, the simpler variant of is_literals had a 0.1% slowdown in case of Symfony, and 2.09% in case of the custom concat benchmark. Personally, I think even the current numbers are acceptable, especially because PHP 8.1 is going to be roughly 30% faster than PHP 8.0 according to my benchmark in case of the Symfony demo app. Laravel's result is very similar, but I don't remember about the exact numbers. Regards: M=C3=A1t=C3=A9 --00000000000022f7f105c6a41c80--