Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115358
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\))
In-Reply-To: <CACNm7o85-wVhD9bp_8KFrWareJAjW_ndBNWjvWzsmqo4gG4k7w@mail.gmail.com>
Date: Wed, 7 Jul 2021 14:15:29 -0700
Cc: Daniel Beardsley <dbeardsl@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-ID: <B9DF3A6B-9443-428E-A4B3-F567675BAAFC@woofle.net>
References: <CACNm7o85-wVhD9bp_8KFrWareJAjW_ndBNWjvWzsmqo4gG4k7w@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [VOTE] Add PDO function: mysqlGetWarningCount
From: dusk@woofle.net (Dusk)

On Jul 6, 2021, at 08:34, Daniel Beardsley <dbeardsl@gmail.com> wrote:
> The proposal:
>> Add a function that exposes the warning count of the most recent
>> statement for MySQL: $pdo->mysqlGetWarningCount(). It returns an int
>> straight from the MySQL driver. This fixes the open bug at:
>> https://bugs.php.net/bug.php?id=3D51499.
>=20
> Voting will be open till 2020-07-21
>=20
> https://wiki.php.net/rfc/pdo-mysql-get-warning-count

The proposed vote declares that that:

> =E2=80=9CYes=E2=80=9D means this pull request should be merged =
(pending code review). =E2=80=9CNo=E2=80=9D means we don't want PDO to =
expose MySQLs warning count.

This seems like a false dichotomy. What response would be appropriate =
for "exposing the MySQL warning count in PDO is fine, but this isn't the =
right way to do it"?

I'm not eligible to vote, but speaking for myself, I'd prefer a more =
generic mechanism for exposing metadata about queries -- not one that's =
specific to MySQL, nor one which only exposes a warning count. For =
example, MySQL also exposes some flags for statements where no index was =
used, and SQLite has functions to obtain the expanded SQL for a =
statement or to check if it's a read-only operation; all of these, along =
with the MySQL warning count, would fit nicely into a more generic PDO =
statement metadata API.

Would it be possible to amend the voting statement to:

> =E2=80=9CYes=E2=80=9D means this pull request should be merged =
(pending code review). =E2=80=9CNo=E2=80=9D means **the pull request =
should not be merged**.

without invalidating existing votes? It would be unfortunate for this =
vote to be interpreted as a rejection of any future PDO API which =
happens to include the MySQL warning count.=