Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115341
MIME-Version: 1.0
References: <CABTDVhD9SKNVFrt8NMj4BqdHmsMpSt0DH=SMmb-9C905rgc7PA@mail.gmail.com>
 <c4d01e7b-0b23-042a-cbe4-623e86dc8a81@php.net> <CABTDVhDOaDj46BG4TxctQAUL8=Bc8FADWU5RaTmSWgMRFAkhkA@mail.gmail.com>
In-Reply-To: <CABTDVhDOaDj46BG4TxctQAUL8=Bc8FADWU5RaTmSWgMRFAkhkA@mail.gmail.com>
Date: Wed, 7 Jul 2021 12:32:12 +0200
Message-ID: <CAF+90c8MabpFieUCsShp=rB1XwCdKBfGfpAyCfszEXyq=06PwQ@mail.gmail.com>
To: Go Kudo <zeriyoshi@gmail.com>
Cc: Remi Collet <remi@php.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000259f2b05c6860e68"
Subject: Re: [PHP-DEV] [RFC] Add Random Extension (before: Add Random class)
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000259f2b05c6860e68
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 6, 2021 at 4:38 PM Go Kudo <zeriyoshi@gmail.com> wrote:

> > 1st
>
> This is to avoid conflicts with the implementation in ext/standard. I don=
't
> want to do it this way either, but I have to do it this way.
> Since random in ext/standard does not use namespaces, I would like to
> change the ext/standard side.
>

To clarify, are you referring to the php_random.h header in ext/standard? I
agree with Remi that the extension should be in ext/random, not
ext/random_ext. We can rename the ext/standard header.

Alternatively, you could also use ext/rng, with names RNG\Random,
RNG\NumberGenerator\XorShift128Plus etc.

Regards,
Nikita


> > 2nd
>
> Although it goes back quite a long time, this implementation was original=
ly
> based on an extension I submitted to PECL.
>
> https://pecl.php.net/package/orng
>
> After I posted this to PECL, I found that an object scope RNG had been
> proposed in the past in the Internals ML, and there was positive feedback
> about it.
>
> https://externals.io/message/112525
>
> However, the proposal never actually took place. This RFC is a realizatio=
n
> of that proposal.
>
> Is that what you asked?
>
> Regards,
> Go Kudo
>
> 2021=E5=B9=B47=E6=9C=886=E6=97=A5(=E7=81=AB) 22:46 Remi Collet <remi@php.=
net>:
>
> > Le 26/06/2021 =C3=A0 02:39, Go Kudo a =C3=A9crit :
> > > Hello Internals.
> > >
> > > RFC has been reorganized for finalization.
> > >
> > > https://wiki.php.net/rfc/rng_extension
> >
> > 1st I dislike the name "random_ext", why this "_ext" part ?
> >
> > 2nd why not following the standard process ?
> >
> > 1/ publish on pecl
> > 2/ merge in php-src if enough success and good feedback
> >
> >
> > Remi
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: https://www.php.net/unsub.php
> >
> >
>

--000000000000259f2b05c6860e68--