Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115330
MIME-Version: 1.0
References: <CAJSGLVMX79-6_NRJ9zfJOhivVrTrjtxcQxT9A_XR6BwPVgpodA@mail.gmail.com>
 <d7973065-b6a9-fdf1-0864-7a6f2ed6216f@alec.pl> <CAJSGLVMobxZzDnK14kzzJXFoWzNECPMmRZnrSRwrsdXAXuOsLg@mail.gmail.com>
 <ea101033-6c1b-3769-de6d-33634eddfeaf@alec.pl> <CAJSGLVMZFijdLrOnfwCG_skzH8=wtpyKvsZH3+-s+0azy68u4A@mail.gmail.com>
In-Reply-To: <CAJSGLVMZFijdLrOnfwCG_skzH8=wtpyKvsZH3+-s+0azy68u4A@mail.gmail.com>
Date: Tue, 6 Jul 2021 16:57:54 +0200
Message-ID: <CAJSGLVP26kvf6M_CrtBmr6CgUmVJmEu6yESsqiR5Fq9zgXtTDA@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000003356dd05c675a676"
Subject: Re: [PHP-DEV] [RFC] Under Discussion: Default User-Agent for cURL
From: paresy@gmail.com (Michael Maroszek)

--0000000000003356dd05c675a676
Content-Type: text/plain; charset="UTF-8"

Dear internals,

I didn't receive any more feedback on this RFC, therefore I would like to
start voting next week on the RFC as is.

Rationale:
- I would like to stick with a distinct curl.user_agent ini option to avoid
the BC break.
- Also using PHP_INI_ALL as the options visibility is matching the core
user_agent options behaviour. That is being able to modify the user_agent
via ini_set during runtime.

Thank you for all the contributions!


Am Di., 29. Juni 2021 um 10:35 Uhr schrieb Michael Maroszek <
paresy@gmail.com>:

> Hi!
>
> Would anyone else be in favor of reusing the user_agent setting for cURL
> despite the BC break?
>
> At the moment all possibilities (user_agent, curl.user_agent
> (PHP_INI_ALL), curl.user_agent (PHP_INI_SYSTEM)) seem to
> have negative votes attached.
>
> I am unsure if it makes sense to go forward with the RFC and if I should
> bring the RFC to a YES/NO vote for the feature itself and the three
> mentioned possibilities to choose from as a secondary vote option.
>
> I'd love to get some help on how to proceed even if the answer might be:
> don't proceed.
>
>
> Am So., 27. Juni 2021 um 09:25 Uhr schrieb Aleksander Machniak <
> alec@alec.pl>:
>
>> On 27.06.2021 08:48, Michael Maroszek wrote:
>> > That's what I also thought when making the PR and therefore I initially
>> > went with PHP_INI_ALL.
>> >
>> > But Tyson made a good point that the curl.cainfo is PHP_INI_SYSTEM and
>> we
>> > might want to be consistent about modes inside an extension.
>>
>> Another option might be PHP_INI_PERDIR (for both). Why? Because that's
>> what's used for (similar) openssl extension configuration.
>>
>> ps. anyway, right now I'm on -1 for the new config option.
>>
>> --
>> Aleksander Machniak
>> Kolab Groupware Developer        [https://kolab.org]
>> Roundcube Webmail Developer  [https://roundcube.net]
>> ----------------------------------------------------
>> PGP: 19359DC1 # Blog: https://kolabian.wordpress.com
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: https://www.php.net/unsub.php
>>
>>

--0000000000003356dd05c675a676--