Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:115256 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 67279 invoked from network); 1 Jul 2021 14:12:00 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 1 Jul 2021 14:12:00 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 978E91804F4 for ; Thu, 1 Jul 2021 07:32:31 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Thu, 1 Jul 2021 07:32:31 -0700 (PDT) Received: by mail-oi1-f171.google.com with SMTP id s17so7564598oij.0 for ; Thu, 01 Jul 2021 07:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KRk1J69RGwOlKRmeoG69Y+bcvvFczpcMY/9UCyV0644=; b=cS/fQxI8ncYde6gKqJTsZZyUuJcQh8uCFUp5GqAjqBWu4qFhydATejslDTkPzR3CmC Ve3UYjvSiQdABUrmVm+/2xxOlM+Q6XpjEZO/whF8nFebjMtK5kQbGJpJ+CvwYTQALbLD rLZjqBV5tSRGNidgftfa/TNXwHGeCff6MZcUBkqt+2pLcjZ6MiPJN97w09vUNFYECC67 SD7/58FIuAy+vQoHhYPD5I4yA+CwNhzpyL/Ll3jq2xYk5oIwsxt0K5SKR1/O2jx9eD3v ALZo3z5IGp7ExkDzKekRnb8oAXWoXISNnXbmdFDQyYCvVYNp+Dj3Q7qHQS/XSWTDJfnp PpVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KRk1J69RGwOlKRmeoG69Y+bcvvFczpcMY/9UCyV0644=; b=czcTOtMVrOxIAU8XDoQhYgWfb0aevKIPYyTGE70o7nkdtW8+CojEOZTTF15SjQVRiv 6AoKd8j8UgCe3UBPT6l97/LjtNcMHpb6zMAbhZqEbvKyilAThGN7uOMMKOI6vgsd1C7M qqTVeqsW7iLryxlUkXqre2JPT0PkTdtvsv2aCiQ6BM+CMZfi+PLGd21URWH2ZgqjD6FG yUumsv55TEr5ztGix+AwrFWgAVOkDuAcekyPrOF23p5MzEZAJFYedwDpX/S0w+cKO5zG 7qAhsIzhPLJB4cCbQQeEVYneQxBD2Dnoec5cBKOXq9Vm2KPNZ83RAryfQ1vnusORQ/aW KIqg== X-Gm-Message-State: AOAM532G/lr7BruaMgUzbXHVdH2W2Jx9YolzR0pIPzb4XWRAf//xUV/L dKyRrezlQoUnPrkbFyKdWi4Fgu7caQVuCSccYH8= X-Google-Smtp-Source: ABdhPJxkWYcKWYkJYm7MXXIi2zGTzLrdFhIcVy22PjhSnIWyHoLgSZ+sdxcms/QC2vD7DCrVVEkMyBh/Jh+uJ2hHArE= X-Received: by 2002:aca:30cf:: with SMTP id w198mr13672960oiw.173.1625149948976; Thu, 01 Jul 2021 07:32:28 -0700 (PDT) MIME-Version: 1.0 References: <07c20336-5911-fc65-e001-3c43a72b6e1c@gmx.de> In-Reply-To: <07c20336-5911-fc65-e001-3c43a72b6e1c@gmx.de> Date: Thu, 1 Jul 2021 21:32:15 +0700 Message-ID: To: "Christoph M. Becker" Cc: Nikita Popov , PHP internals Content-Type: multipart/alternative; boundary="0000000000006a610d05c610b568" Subject: Re: [PHP-DEV] [VOTE] Deprecations for PHP 8.1 From: pierre.php@gmail.com (Pierre Joye) --0000000000006a610d05c610b568 Content-Type: text/plain; charset="UTF-8" On Thu, Jul 1, 2021, 9:14 PM Christoph M. Becker wrote: > On 01.07.2021 at 14:15, Pierre Joye wrote: > > > Hi Nikita, > > > > On Wed, Jun 30, 2021, 4:32 PM Nikita Popov wrote: > > > >> Hi internals, > >> > >> I have opened voting on https://wiki.php.net/rfc/deprecations_php_8_1. > The > >> vote closes on 2021-07-14. > >> > >> This RFC is a collection of various deprecation suggestions from > different > >> people. Each deprecation is voted separately, and should be considered > on > >> its own merit. > >> > >> Most deprecations should be uncontroversial, but there are some more > >> contentious ones as well: See https://externals.io/message/113657 for > >> additional discussion. > > > > I hope the num_points do not pass. However if it does, I would like to > > still reconsider it for the reasons I mentioned in the discussion: > support > > nightmare > > > > Any image will be broken if a server is not configured smoothly for > prod. > > Unlike another script, the depreciation is not visible directly in the > > page. Given the amount of usages of these functions out there, I really > ask > > to reconsider this one. Too much possible hassles for no real gain. > > In my opinion, *not* having a signature like > > function imagepolygon( > GdImage $image, > array $points, > int $num_points_or_color, > ?int $color = null > ): bool {} > > and the respective implementation mess, is a gain; not a huge gain, but > still a real gain to me. > > And image generation code which relies on display_errors to catch errors > is already broken. By your argument, we could not even introduce new > warnings. > > Anyhow, fixing the deprecated code would be trivial (the RFC shows an > example), and can even be automated, and I consider it not unlikely that > code which runs on PHP 8 has unit-tests and/or static analysis what may > catch this issue early. The codes which will do this are not the ones I am worrying about. This is not some function never used before but anyone out there. Or something that causes pains to the engine or prevents major features to happen. This function has to be replaced, not made incompatible. best Pierre --0000000000006a610d05c610b568--