Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:115243 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 45257 invoked from network); 30 Jun 2021 13:49:59 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 30 Jun 2021 13:49:59 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id CA9C6180501 for ; Wed, 30 Jun 2021 07:10:12 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 30 Jun 2021 07:10:09 -0700 (PDT) Received: by mail-lj1-f182.google.com with SMTP id u20so3433152ljo.12 for ; Wed, 30 Jun 2021 07:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sgxFuPJwt+t/Ta6MHDLd7mx/G0DMmf70LfuztPOvM5w=; b=de2SU7GVSk4jXwGAua9Bqk+T72NXRTbPLcrwG9beW8mzwl40vNohyMYS2gK6IDAbA0 AfQP1k4d0S3l8H4ElbedwmkA4ER8Sq5uiyp8KBmzMyibAsHmbL3iL9JGHx2z6lxRZXcg 5oMTG2NnsdhAUiMXBR89gJmRsgQlEa5US3Rhe5DYI/yKy20tMqcVSoGQz//wUvgLbYX6 4H7VsPkWMZblUzWO7loffQ3E9ST6ffgQJkgSCcYXABg9wAM2are7yJ07qTZ1Lm+LcP2L W19wVg1hb3B2kbzPUYJYOEkkKzNfogtgkamjb0/FIMPN0JhapL8uZMSK4ydoiqsXMeOa xqsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sgxFuPJwt+t/Ta6MHDLd7mx/G0DMmf70LfuztPOvM5w=; b=CURZRvwZu71DUwx69t+wVrTWcd/g2x7wQJ0F54Tq/CNcdkPYN/dh0AgeLgTT7b78QL /OM9xVRbFIEFfEcbXRRNZrFfrFGhpaxz/IZkpuGCJA8/+33ddBc4DhbqojWWZRwAmHPS PuXXiEbFAAQjCp0BV7wqFF+nyNNYolQYOce5RnM3kNJpnOg2Kvk12zN7HvRRi4ZlIUUs yaVMR9mizyIkMaIb6XubrChlYjMF1fIM4/1ONmf+N/d4Rz+yuJ6hf1qhoJZ3m3BvPyzW f0oBWWQ/HzggjEGBkeL6P/Hlso3T/tYAoGyrlJIm7rmaV5kYFUo0YHS58tonvcOC5Ck9 ID4w== X-Gm-Message-State: AOAM531mqz8AMuAVLqm8FnHx3Smaw4IA62D7vmGKWEi3zgdHoIH2UxQz Bd3kr8xt9fLq6B1eL1BBCBMghrqjM/XULULjxKo= X-Google-Smtp-Source: ABdhPJyWTCZ4vlE1qvmXkUZn1OmiE2zAtxjjE5mPoZPeVfvANDIOFZmQJzjqamy1qIzcdA7taX1w3Q0nVBp23kA04Po= X-Received: by 2002:a2e:b0cb:: with SMTP id g11mr8162466ljl.196.1625062205409; Wed, 30 Jun 2021 07:10:05 -0700 (PDT) MIME-Version: 1.0 References: <9d6kdgthgqvc5a75ta99hkptqoe5soei3k@4ax.com> In-Reply-To: Date: Wed, 30 Jun 2021 09:09:53 -0500 Message-ID: To: Stephen Reay Cc: php internals Content-Type: multipart/alternative; boundary="0000000000007dcc1805c5fc4706" Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1 From: neclimdul@gmail.com (James Gilliland) --0000000000007dcc1805c5fc4706 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jun 30, 2021 at 5:30 AM Stephen Reay wrote: > > > > On 29 Jun 2021, at 02:28, Jan Ehrhardt wrote: > > > > Nikita Popov in php.internals (Mon, 22 Mar 2021 10:24:51 +0100): > >> Hi internals, > >> > >> It's time for another deprecation RFC: > >> https://wiki.php.net/rfc/deprecations_php_8_1 > > > > FWIW, a quick search returned these results. > > > > ADOdb still uses strftime() > > https://adodb.org/dokuwiki/doku.php > > > > 2 plugins of Matomo (formerly Piwik) still uses strftime in > > Login/PasswordResetter.php and RssWidget/RssRenderer.php > > > > The simplepie library still uses strftime: > > > https://github.com/simplepie/simplepie/blob/717d9ea4bf1a8533d5a26128b7acc= 1598388ce66/library/SimplePie/Item.php#L882 > > > > Limesurvey still uses strftime, in the ADOdb functions and in the > kcfinder > > functions: > > > https://github.com/LimeSurvey/LimeSurvey/blob/6437c998731e1e79da24c394ef2= 05444cfa75cdf/third_party/kcfinder/core/class/browser.php#L784 > > > > Drupal 7 uses strftime in the date module and in the views module: > > https://www.drupal.org/project/date > > See date/date_api/date_api_sql.inc > > https://www.drupal.org/project/views > > See views/includes/handlers.inc > > > > Drupal 8 uses strftime. Example: > > > https://api.drupal.org/api/drupal/core!modules!views!src!Plugin!views!que= ry!Sql.php/function/Sql%3A%3AgetDateFormat/8.2.x > > -- > > Jan > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: https://www.php.net/unsub.php > > > > (Bah! Sending again to the list, because me stupid) > > I=E2=80=99m sure some of those are legitimate - but to my eye, the Drupal= 8 > example at least, is _not_ using `strftime` in *PHP*. > > I believe it=E2=80=99s making use of the `strftime` function in SQLite. > Was surprised to see Drupal in the list but that makes sense. Confirmed those D7 views and date modules are doing the same thing and using the sqlite function, not PHP's. This made me suspicious about adodb since it is also doing database abstraction and searching their github source the best I can tell all the calls in it are _also_ to the sqlite function, not php's. --0000000000007dcc1805c5fc4706--