Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115164
MIME-Version: 1.0
References: <CAJSGLVMX79-6_NRJ9zfJOhivVrTrjtxcQxT9A_XR6BwPVgpodA@mail.gmail.com>
 <d7973065-b6a9-fdf1-0864-7a6f2ed6216f@alec.pl>
In-Reply-To: <d7973065-b6a9-fdf1-0864-7a6f2ed6216f@alec.pl>
Date: Sun, 27 Jun 2021 08:48:31 +0200
Message-ID: <CAJSGLVMobxZzDnK14kzzJXFoWzNECPMmRZnrSRwrsdXAXuOsLg@mail.gmail.com>
To: Aleksander Machniak <alec@alec.pl>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008a1da405c5b9c3bc"
Subject: Re: [PHP-DEV] [RFC] Under Discussion: Default User-Agent for cURL
From: paresy@gmail.com (Michael Maroszek)

--0000000000008a1da405c5b9c3bc
Content-Type: text/plain; charset="UTF-8"

Hi Aleksander,

That's what I also thought when making the PR and therefore I initially
went with PHP_INI_ALL.

But Tyson made a good point that the curl.cainfo is PHP_INI_SYSTEM and we
might want to be consistent about modes inside an extension.

I'd love to hear some more opinions on which direction we should go.

> Imo, the fact that curl is not using user_agent setting is a bug and
> should be fixed, even with BC break. We really don't need another setting.

That was my option B, but in my opinion this feature is too minor and
therefore not worth the BC break.

Regards
Michael


Am Sa., 26. Juni 2021 um 09:20 Uhr schrieb Aleksander Machniak <alec@alec.pl
>:

> On 25.06.2021 16:33, Michael Maroszek wrote:
> >
> > Please have a look at the full RFC:
> https://wiki.php.net/rfc/curl_user_agent
> >
> > There is one open issue which Tyson raised to find the correct mode for
> the
> > ini option. Either PHP_INI_ALL or PHP_INI_SYSTEM is currently being
> > discussed. See here for all details:
> > https://github.com/php/php-src/pull/6834/files#r628774432
>
> The existing user_agent setting is PHP_INI_ALL. Please, don't make it
> different.
>
> Imo, the fact that curl is not using user_agent setting is a bug and
> should be fixed, even with BC break. We really don't need another setting.
>
> --
> Aleksander Machniak
> Kolab Groupware Developer        [https://kolab.org]
> Roundcube Webmail Developer  [https://roundcube.net]
> ----------------------------------------------------
> PGP: 19359DC1 # Blog: https://kolabian.wordpress.com
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--0000000000008a1da405c5b9c3bc--