Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:115156 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 99125 invoked from network); 26 Jun 2021 12:27:50 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 26 Jun 2021 12:27:50 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 9CB1E1804C0 for ; Sat, 26 Jun 2021 05:47:05 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sat, 26 Jun 2021 05:47:05 -0700 (PDT) Received: by mail-wr1-f51.google.com with SMTP id l12so13133035wrt.3 for ; Sat, 26 Jun 2021 05:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:user-agent:in-reply-to:references:mime-version :content-transfer-encoding:subject:to:from:message-id; bh=8tD4NDEszJsiEFSWUThNJAOtdZ0YgtCxI0dNek+TS1Q=; b=rO1lj2cBUeHAs0CfSnaw2AfAoiTzXqOCtBMkNRtgL5eYvEBgH61py6gH85gzy/utE8 1Z13ecHG3Mb4FJlDkcxG4qrDbA89B1Sd1zZpZCO/XuGFg4KQN7pyidxnnQ56F/6ZG56V FWP1B3dYe7ELiFiiVI3xb1qOkGqOHTV3Xjomd9pKKwxbe5KmN5navgkDqZTKGzAJ+qin N5m+/Jizeqet4X6Keb5AvMZISsjMrJutSkX51uuDvUXxseE4IS0dihNqclukH5HstWsy QK1f07Pzk+0758yDM1nyHcTyi0ebj2CJaHrBpxemIOXCjUYhN2LW3mQNCeOrYh1FIBDJ HSnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:user-agent:in-reply-to:references :mime-version:content-transfer-encoding:subject:to:from:message-id; bh=8tD4NDEszJsiEFSWUThNJAOtdZ0YgtCxI0dNek+TS1Q=; b=MjMcerAujSqFODCR6If+vnYpaWmNdXrTSyVV7PVEW4nNQGEL8fJKNXRptI2z3yMS35 Z8pB/GAkMOewanoShYXwaKXklFIua18RToFC5jYklugPJA+3yO4phzrFcb2ELtmBiY+2 pAlkEYGTeqoBv0a8cpjxP3PBednjhmHflcRVIRdFXIdhJZf1Ud64XxWGkvUNvB6hprWt CkqPZIk9cr1wFza7mCa6uomRFYYxvUaVtcsOeiT0d2apjIHLw3F6SrnE473gPrRFdRXm 8r3HPdQmajCb+xv/sJKf9OmAu3u3T3mRgG3pGixIo3dvQ506rT620PNgo1QygSugEW7g thtg== X-Gm-Message-State: AOAM533zUGmDE1YA/eTkk9W4JFyHdWVrUx+hcf2CyWSwqHG6aC9HNdqj /lAAujoUzsJH70tbagRnnyeYzykiKWo= X-Google-Smtp-Source: ABdhPJzPiVWKZQCKRXQ/NTECWCGjTr6AuQ03attlxd1Tr2Gmah4mUwdHMZhU3JBREPujFWHrYaRhOw== X-Received: by 2002:adf:fc82:: with SMTP id g2mr16672632wrr.323.1624711623874; Sat, 26 Jun 2021 05:47:03 -0700 (PDT) Received: from [192.168.0.27] (cpc104104-brig22-2-0-cust548.3-3.cable.virginm.net. [82.10.58.37]) by smtp.gmail.com with ESMTPSA id j13sm8812651wrq.62.2021.06.26.05.47.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Jun 2021 05:47:03 -0700 (PDT) Date: Sat, 26 Jun 2021 13:47:05 +0100 User-Agent: K-9 Mail for Android In-Reply-To: References: <95D16F2E-E9DD-4964-A0E2-62E1FB0D976B@koalephant.com> <4DE5E2EC-26D6-4D2C-95A9-B843B440EE87@koalephant.com> <26037CB4-4723-4DC5-BD92-BBDC4F548E17@koalephant.com> <24E12B58-7613-4E67-852C-3312F4AE769C@newclarity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable To: internals@lists.php.net Message-ID: <64D2FC1D-E4BA-46E7-A19E-3A7DE35B2096@gmail.com> Subject: Re: [PHP-DEV] [RFC] Name issue - is_literal/is_trusted From: rowan.collins@gmail.com (Rowan Tommins) On 26 June 2021 13:24:55 BST, Dan Ackroyd wrote: >It allows silly mistakes to slip through and make it to production=2E As > per https://news-web=2Ephp=2Enet/php=2Einternals/114858: Perhaps you missed my reply earlier where I pointed out that the traceabil= ity problem you've identified is valid, but not solved by removing the flag= on concatenation: https://news-web=2Ephp=2Enet/php=2Einternals/114868 Regardless of whether you get an error message from assert(is_literal($foo= ) && is_literal($bar)) or literal_concat($foo, $bar) the actual big will al= most certainly have happened somewhere else in the program, and you'll need= to trace the data flow of $foo and $bar to find out where=2E To avoid that, you'd have to avoid propagating the flag on *any* operation= , including assignment and return statements, which would clearly be pretty= pointless=2E >Also, I'm going to cross-post this, as it's unreasonable to expect >people to read all of the different threads=2E Please don't=2E All it will achieve is more list traffic, more fragmentati= on, and more messages that people who aren't interested have to ignore=2E Regards, --=20 Rowan Tommins [IMSoP]