Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:11513 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99455 invoked by uid 1010); 23 Jul 2004 15:54:26 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 99070 invoked from network); 23 Jul 2004 15:54:24 -0000 Received: from unknown (HELO asuka.prohost.org) (69.196.31.138) by pb1.pair.com with SMTP; 23 Jul 2004 15:54:24 -0000 Received: (qmail 7445 invoked from network); 23 Jul 2004 15:54:24 -0000 Received: from rei.nerv (HELO dummy.com) (rei@192.168.1.1) by asuka.nerv with SMTP; 23 Jul 2004 15:54:24 -0000 Reply-To: ilia@prohost.org To: internals@lists.php.net, Marcus Boerger , Andi Gutmans Date: Fri, 23 Jul 2004 11:54:27 -0400 User-Agent: KMail/1.6.1 References: <5.1.0.14.2.20040722142013.02cd0890@127.0.0.1> <5.1.0.14.2.20040723084206.02cb36c8@127.0.0.1> In-Reply-To: <5.1.0.14.2.20040723084206.02cb36c8@127.0.0.1> Organization: Prohost.org MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-ID: <200407231154.27051.ilia@prohost.org> Subject: Re: [PHP-DEV] Memory leak From: ilia@prohost.org (Ilia Alshanetsky) On July 23, 2004 11:42 am, Andi Gutmans wrote: > Why do we need one extra byte? We do not. > Anyway, the question is if we should return to alloca() or not. I am > slightly in favor but don't feel very strongly about it. Perhaps we could try a combination of the two, to ensure that no script is terminated due to a PHP crash if allocating on the stack fails. By default we can use alloca() if that fails to allocate the memory, we could use emalloc() and set a flag free code indicating which free function should be used. Ilia