Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115126
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
In-Reply-To: <919141bc-9b59-48f4-929f-6f0434dd7317@www.fastmail.com>
Date: Thu, 24 Jun 2021 19:12:28 +0200
Cc: php internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <F53A1ED5-7951-4AC3-A4CB-7C53A609D896@gmail.com>
References: <222b3921-3d9b-47f9-8d13-e6a123f36fad@www.fastmail.com>
 <919141bc-9b59-48f4-929f-6f0434dd7317@www.fastmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Subject: Re: [PHP-DEV] [Vote] Partial Function Application
From: claude.pache@gmail.com (Claude Pache)



> Le 24 juin 2021 =C3=A0 18:02, Larry Garfield <larry@garfieldtech.com> =
a =C3=A9crit :
>=20
> On Wed, Jun 16, 2021, at 11:16 AM, Larry Garfield wrote:
>> Hi folks.  The vote for the Partial Function Application RFC is now=20=

>> open, and will run until 30 June.
>>=20
>> https://wiki.php.net/rfc/partial_function_application
>>=20
>> Of particular note, a few people had asked about using ...? instead =
of=20
>> ... for the variadic placeholder.  In the end we decided not to =
explore=20
>> that, as Nikita explained off-list it was actually more confusing, =
not=20
>> less, as it would suggest "placeholder for a variadic" rather than "a=20=

>> placeholder that is variadic."  Otherwise, it's just more typing.  =
The=20
>> syntax choices section of the RFC has been updated accordingly.
>=20
> Since some people still don't grok the use cases, I've written a blog =
post to make the case for them better than a detail-oriented RFC can.
>=20
> =
https://peakd.com/hive-168588/@crell/the-case-for-partials-and-pipes-in-ph=
p
>=20
> There has also been some positive Twitter chatter, as well as the =
level of +1s on that post (which is, I think, the highest of any PHP =
post I've had on there, ever), so I think the demand for it is =
definitely there in the ecosystem.  It's just not people who frequent =
Internals. :-/
>=20
> I'd say there are definitely people that want to use partials.
>=20
> --Larry Garfield
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>=20

Hi,

In the blog post, you are not fair when comparing:

```
Request::fromGlobals()
   |> normalize_path(?)
   |> oauth_check(?)
   |> parse_body($dbconn, ?)
   |> $resolver->resolveController(?)
   |> controller_caller(?)
   |> response_handler(?, $theme_system)
   |> $add_cache_headers(?)
   |> send_response(?)
;
```

with:

```
Request::fromGlobals()
  |> fn(ServerRequestInterface $request): ServerRequestInterface =3D> =
normalize_path($request)
  |> fn(ServerRequestInterface $request): ServerRequestInterface =3D> =
oauth_check($request)
  |> fn(ServerRequestInterface $request): ServerRequestInterface =3D> =
parse_body($dbconn, $request)
  |> fn(ServerRequestInterface $request): ServerRequestInterface =3D> =
$resolver->resolveController($request)
  |> fn(ServerRequestInterface $request): ResponseInterface =3D> =
controller_caller($request)
  |> fn(ResponseInterface $response): ResponseInterface =3D> =
response_handler($response, $theme_system)
  |> fn(ResponseInterface $response): ResponseInterface =3D> =
$add_cache_headers($response)
  |> fn(ResponseInterface $response): ResponseInterface =3D> =
send_response($response)
;
```

I would write it the following way:

```
Request::fromGlobals()
  |> fn($_) =3D> normalize_path($_)
  |> fn($_) =3D> oauth_check($_)
  |> fn($_) =3D> parse_body($dbconn, $_)
  |> fn($_) =3D> $resolver->resolveController($_)
  |> fn($_) =3D> controller_caller($_)
  |> fn($_) =3D> response_handler($_, $theme_system)
  |> fn($_) =3D> $add_cache_headers($_)
  |> fn($_) =3D> send_response($_)
;
```

The version with partials is still better as it has less grawlix, but =
the difference between the two is considerably reduced. Style can make a =
big difference in readability.

Also, without pipes or partials, it could be written as:

```
$_ =3D Request::fromGlobals();
$_ =3D normalize_path($_);
$_ =3D oauth_check($_);
$_ =3D parse_body($dbconn, $_);
$_ =3D $resolver->resolveController($_);
$_ =3D controller_caller($_);
$_ =3D response_handler($_, $theme_system);
$_ =3D $add_cache_headers($_);
send_response($_);
```
where my `$_`s play the role of your `?`s.

(I still do find that pipes and partials would be nice additions, but it =
is not something that I am desperately craving after.)

=E2=80=94Claude