Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:11512
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <5.1.0.14.2.20040723084206.02cb36c8@127.0.0.1>
Date: Fri, 23 Jul 2004 08:42:45 -0700
To: Marcus Boerger <helly@php.net>
Cc: internals@lists.php.net
In-Reply-To: <1938036338.20040723084456@marcus-boerger.de>
References: <5.1.0.14.2.20040722142013.02cd0890@127.0.0.1>
 <5.1.0.14.2.20040722142013.02cd0890@127.0.0.1>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
Subject: Re: [PHP-DEV] Memory leak
From: andi@zend.com (Andi Gutmans)

Why do we need one extra byte?
Anyway, the question is if we should return to alloca() or not. I am 
slightly in favor but don't feel very strongly about it.

Andi

At 08:44 AM 7/23/2004 +0200, Marcus Boerger wrote:
>Hello Andi,
>
>the easiest way to make the test suit for 5.1 work again is to
>change zend_execute.c line 1352 to:
>EX(Ts) = (temp_variable *) safe_emalloc(sizeof(temp_variable), 
>op_array->T, 1);
>
>notice the 1 instead of 0 which allocates one additional byte for every
>execution.
>
>regards
>marcus
>
>Thursday, July 22, 2004, 11:25:57 PM, you wrote:
>
> > The executor() change from alloca() to emalloc() seems to have introduced a
> > memory leak (found it with --enable-debug). Before I try and fix it, are we
> > reverting back to do_alloca(), free_alloca()? (even though we should see
> > why this memory leak is happening anyway because we don't always use
> > alloca() for do_allocat()).
>
> > Andi
>
>
>
>
>--
>Best regards,
>  Marcus                            mailto:helly@php.net