Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115118
Message-ID: <81EDE991-60C8-4DF8-9D1E-1B2BAE144829@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_0BE5AA7E-A3FF-4DE3-8F3A-D36BE46907BB"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Date: Thu, 24 Jun 2021 16:38:19 +0200
In-Reply-To: <CAMSJsBDdfnbge_digZVPfUme2y1V-XGmstUzpTmk9zJ1R7fdRQ@mail.gmail.com>
Cc: internals@lists.php.net
To: =?utf-8?B?0JTQvNC40YLRgNC40Lkg0JXQu9C40YHQtdC10LI=?= <elisdnru@gmail.com>
References: <CAMSJsBDdfnbge_digZVPfUme2y1V-XGmstUzpTmk9zJ1R7fdRQ@mail.gmail.com>
Subject: Re: [PHP-DEV] Checking that Closure is static
From: claude.pache@gmail.com (Claude Pache)

--Apple-Mail=_0BE5AA7E-A3FF-4DE3-8F3A-D36BE46907BB
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> Le 18 juin 2021 =C3=A0 16:35, =D0=94=D0=BC=D0=B8=D1=82=D1=80=D0=B8=D0=B9=
 =D0=95=D0=BB=D0=B8=D1=81=D0=B5=D0=B5=D0=B2 <elisdnru@gmail.com> a =
=C3=A9crit :
>=20
> Hello! When I use a static anonymous function as an HTTP-action in
> some frameworks like:
>=20
> $app =3D new App();
> $app->get('/', static function () {
>   return new Response('Hello!);
> })
>=20
> I get a warning "Cannot bind an instance to a static closure" in every
> $closure->bind($container) call inside of the framework.
>=20
> But right now I cannot prevent this warning because there is no native
> way to check that closure is static before calling the bind method. I
> can only suppress the warning with @ or set/restore_error_handler
> pair.
>=20
> So I propose to add a method like Closure::isStatic (or
> Closure::canBeBound, etc.) for ability of manual checking it before
> bind call:
>=20
> if (!$closure->isStatic()) {
>   $closure->bind($object);
> }
>=20
> The method can contain simple statement:
>=20
> return func->common.fn_flags & ZEND_ACC_STATIC;
>=20
> It will be helpful if somebody needs to support dynamic and static
> callables both without warnings.
>=20
> -- Best, Dmitry

I think that the Warning should be removed entirely, and the `bindTo()` =
method should be a no-op when applied to a static closure.

That the closure is implemented as static, or as non-static without =
actually using `$this`, is an implementation detail that the user of the =
closure doesn=E2=80=99t need to be aware.

As a precedent, it is perfectly legal to call a static class method on =
an instance of that class: https://3v4l.org/5QKsN =
<https://3v4l.org/5QKsN>=20

=E2=80=94Claude


--Apple-Mail=_0BE5AA7E-A3FF-4DE3-8F3A-D36BE46907BB--