Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115111
MIME-Version: 1.0
References: <012901d7683a$446a7ba0$cd3f72e0$@gmail.com> <CAESVnVrFX9MWBQZPnkas+hJBgatOsuT_g1wpOcDstcD09+qASg@mail.gmail.com>
 <C58053AC-0692-4E40-AEFB-D60893665588@newclarity.net> <CAESVnVo78NNaOKCQt27y0AN6Jysw2DHFWUOoTkToh+Onj7EZUw@mail.gmail.com>
 <CAC5V6ggxe_brHoYcSwuqLa+nhZWUKiKLNOvnxkB0dA43RPok=w@mail.gmail.com> <CAGBsUrcbbuH2x73CetrUyJbmgN_4XJ-0f7X8pjeuNrdXNMd15Q@mail.gmail.com>
In-Reply-To: <CAGBsUrcbbuH2x73CetrUyJbmgN_4XJ-0f7X8pjeuNrdXNMd15Q@mail.gmail.com>
Date: Thu, 24 Jun 2021 13:38:49 +0200
Message-ID: <CAC5V6gg=jxvDTLMqfxKGb73X6y6gy4g+GtDazxmyk8_dyo0rBw@mail.gmail.com>
To: Kamil Tekiela <tekiela246@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000019310d05c5817878"
Subject: Re: [PHP-DEV] Introduce str_left/right In 8.1
From: guilliam.xavier@gmail.com (Guilliam Xavier)

--00000000000019310d05c5817878
Content-Type: text/plain; charset="UTF-8"

On Thu, Jun 24, 2021 at 1:17 PM Kamil Tekiela <tekiela246@gmail.com> wrote:

> I am against adding these functions, but for different reasons than Sara
> and George.
> If we add str_left and str_right then there should be a corresponding
> variant in mbstring. The byte-string functions are rarely useful. Adding
> these functions to mbstring unnecessarily complicates the extension for
> little to no gain.
>

So you seem to relate to Christoph's (and Rowan's) point.


> Another point is that if we decide to add them, then we will bikeshed
> forever in an unresolvable manner about the name. Should it be called
> str_left or strleft? Current functions don't have a naming convention, so
> using either variant will be wrong.
>

To be fair, most "strxxx" functions were historically more-or-less copied
from C; most recent additions have been "str_xxx".


> Personally, I find substr to be more clear about the intent. I know that I
> am asking for a part of the string. Whereas str_left doesn't convey an
> action immediately. Without knowing its purpose I wouldn't know if it will
> pad the string from the left, strip characters from left, or take the
> leftmost part of the string.
>

True, I can also imagine bikeshed like "str_leftmost", "str_start",
"str_first[_n]" (and same for rightmost/end/last)...


> Don't take it the wrong way, but I think it's a waste of time to implement
> a function that doesn't even need a polyfill in the userland.
>
> Regards,
> Kamil
>

-- 
Guilliam Xavier

--00000000000019310d05c5817878--