Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115110
MIME-Version: 1.0
References: <012901d7683a$446a7ba0$cd3f72e0$@gmail.com> <CAESVnVrFX9MWBQZPnkas+hJBgatOsuT_g1wpOcDstcD09+qASg@mail.gmail.com>
 <C58053AC-0692-4E40-AEFB-D60893665588@newclarity.net> <CAESVnVo78NNaOKCQt27y0AN6Jysw2DHFWUOoTkToh+Onj7EZUw@mail.gmail.com>
 <CAC5V6ggxe_brHoYcSwuqLa+nhZWUKiKLNOvnxkB0dA43RPok=w@mail.gmail.com>
In-Reply-To: <CAC5V6ggxe_brHoYcSwuqLa+nhZWUKiKLNOvnxkB0dA43RPok=w@mail.gmail.com>
Date: Thu, 24 Jun 2021 12:17:26 +0100
Message-ID: <CAGBsUrcbbuH2x73CetrUyJbmgN_4XJ-0f7X8pjeuNrdXNMd15Q@mail.gmail.com>
To: Guilliam Xavier <guilliam.xavier@gmail.com>
Cc: Sara Golemon <pollita@php.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000076f9f705c5812b13"
Subject: Re: [PHP-DEV] Introduce str_left/right In 8.1
From: tekiela246@gmail.com (Kamil Tekiela)

--00000000000076f9f705c5812b13
Content-Type: text/plain; charset="UTF-8"

I am against adding these functions, but for different reasons than Sara
and George.
If we add str_left and str_right then there should be a corresponding
variant in mbstring. The byte-string functions are rarely useful. Adding
these functions to mbstring unnecessarily complicates the extension for
little to no gain.
Another point is that if we decide to add them, then we will bikeshed
forever in an unresolvable manner about the name. Should it be called
str_left or strleft? Current functions don't have a naming convention, so
using either variant will be wrong.
Personally, I find substr to be more clear about the intent. I know that I
am asking for a part of the string. Whereas str_left doesn't convey an
action immediately. Without knowing its purpose I wouldn't know if it will
pad the string from the left, strip characters from left, or take the
leftmost part of the string.
Don't take it the wrong way, but I think it's a waste of time to implement
a function that doesn't even need a polyfill in the userland.

Regards,
Kamil

--00000000000076f9f705c5812b13--