Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:115109 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 66554 invoked from network); 24 Jun 2021 10:50:39 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 24 Jun 2021 10:50:39 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 036A81804CC for ; Thu, 24 Jun 2021 04:09:24 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Thu, 24 Jun 2021 04:09:23 -0700 (PDT) Received: by mail-wr1-f53.google.com with SMTP id i94so6198253wri.4 for ; Thu, 24 Jun 2021 04:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=cuam3hS9aKiFHWX3SM23ZfggkKjKYgUnDAnhKI3PiVg=; b=oLDI1LU5GKFOmhTw/ZYT0AnTPE0tn4c8cYkvbsSWRmszeX/JPAOIINpvB4PTBu+PrH YP+FQXlFLm0KgbCYj7i3011ZZ79ru2Y0+zYSC4Cc3OHi/4Gf0c4oDP/21sXilSkag88K ALTFpl1uiPn/PLSRcJZrxh84lb5vrtH6EppvK2VSi/zsc4/3xzEJwvSkdzZPwc6scVve 3J40ECJNKjdt/j+uPwEe+bBvjQQCG9+Mth+lL0p5iH/K+EG7EjvqPPuz6+2+S328ExAm dbxIQ7YcqwVI2qFX+S7zCf2TLNBntuPui7q7TPP5MCuGjIHNGDXgjEzvKPDfXihiaVYt vE4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=cuam3hS9aKiFHWX3SM23ZfggkKjKYgUnDAnhKI3PiVg=; b=ms5CrpxN8ibxEonK5x5zEZddQno2UsNcw7DQlxsL9RbNgntx3GF+veeF2KbONqyrUv y5634R4d+muYaw+PZdIfpNHw3WT2AaCY06qKX61D8Iv6Kx0P5hyJT4uccQBaNzJFDjey GIIMSCUMmaHwzcSepLD5zSRao5CfGlpDLxNltkWDRAllsGlfT4sE+5RSUQMB7AWkqAlS bOOhGET/mosOQQyudFwB7gQbS30tzxzpb/dNh36v+l2SXTyg90AfIp8QN3jtuP+6MXnh 1FQRM4MJjMiJibzSFx/J5hyGnkPg94iRrB9bADqUpSbW/MsYowENz2dHyranfdW82/q8 C3/Q== X-Gm-Message-State: AOAM533YTwu9UgaWX0kJJTPXOny5hW71H4jj0Lmnb3IaAWhCnXfKX5Rs idddI8Q3mLnfUuYAW66dUcsYxTwXSEM= X-Google-Smtp-Source: ABdhPJw93BB6Q6X2GdthNa8EfzRpAU7k43n+k9EKrKU9hqbyLPmeT4SqcRiGruct+sc9WUZBriw9cw== X-Received: by 2002:adf:fc43:: with SMTP id e3mr3811845wrs.212.1624532961188; Thu, 24 Jun 2021 04:09:21 -0700 (PDT) Received: from [192.168.0.22] (cpc104104-brig22-2-0-cust548.3-3.cable.virginm.net. [82.10.58.37]) by smtp.googlemail.com with ESMTPSA id m5sm9373271wmg.32.2021.06.24.04.09.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 04:09:20 -0700 (PDT) To: internals@lists.php.net References: <03f7955c-69a8-4841-9245-449d7851e207@www.fastmail.com> <95D16F2E-E9DD-4964-A0E2-62E1FB0D976B@koalephant.com> <4DE5E2EC-26D6-4D2C-95A9-B843B440EE87@koalephant.com> Message-ID: Date: Thu, 24 Jun 2021 12:09:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [PHP-DEV] [RFC] Name issue - is_literal/is_trusted From: rowan.collins@gmail.com (Rowan Tommins) On 24/06/2021 11:35, Stephen Reay wrote: >> On 24 Jun 2021, at 17:16, Craig Francis wrote: >> >> On Thu, 24 Jun 2021 at 10:55, Stephen Reay wrote: >> >>> but still I have to keep asking: Why integers at all? >>> >> >> While I'm not a fan of this approach, there is a lot of existing code and >> tutorials that use: >> >> $sql = 'WHERE id IN (' . implode(',', array_map('intval', $ids)) . ')'; >> >> $sql = sprintf('SELECT * FROM table WHERE id = %d;', intval($id)); > Yeah you’ve said this about a dozen times now. Parameterisation exists. Query builders that do this already using parameterisation, exist. I think it's clear that a conversation is going round in circles if you are complaining both that you haven't had an answer to your question, and that you've had the same answer too many times. If you understand the answer but disagree with it, there is nothing more to be said. Unless you have a new point to make, I think it's probably best to "agree to disagree" at this point, particularly as the discussion seems to be getting heated and personal, which is not fun for anyone. Regards, -- Rowan Tommins [IMSoP]