Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:115089 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 4390 invoked from network); 24 Jun 2021 00:07:48 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 24 Jun 2021 00:07:48 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 276D41804DA for ; Wed, 23 Jun 2021 17:26:25 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 23 Jun 2021 17:26:24 -0700 (PDT) Received: by mail-lf1-f45.google.com with SMTP id j4so7130160lfc.8 for ; Wed, 23 Jun 2021 17:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=craigfrancis.co.uk; s=default; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YJWWD4tJhlG9WojqwSwwQUQEK305Rmpj+s4ad4NswlU=; b=U3+01ssrAuTHxfeH/y+6CKujUIOSL4aJSiUW8Mxmg1HeylaNNoBO+CxbERbGytFbLJ ggfANmlZX+q4d8FzRLwwPYCJmR0l/q1RsnuAUKruKq9jTvudcyZ6zpzUkmxKWuW6sudn sz5L7UM1upuxDXZVvIQnvtyulqBLCms83CPuA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YJWWD4tJhlG9WojqwSwwQUQEK305Rmpj+s4ad4NswlU=; b=bi2KWHuVC6uRVWHZry1TtkNC1s4br+6qM56pPo0gz6kEivB1BIkkoF+yN/qHpBdPbj nHzJYK1IbnHU/serLN25p+dftcLlSv7UQBoEAT3j0XKEeYY4apYRfc5oWspaauint3ps 94WGc+hjPjwl6h2MqylkM89Rci8msNLjps53DmK1nwx7BUoAmPW75B/KkGVRus2pfI1u RHxIwnBICm5XG4yT8tpqE5BP5x7qY+ww0l4aBSHI2cVKSvfLM2ZI1+T3mu5zJbvjD6mJ BPE9Q0sIz/BL5SmSDtoJnq58hru3HqGQvBHgdRA2qrGQkFPPDCG0tyyaLQuEz3VT4JBe AUcA== X-Gm-Message-State: AOAM533ihqc64HZ9/u1olcywt2r3U9bpcHHl7vcRzfyXOTR5UU2vQBuH 0z4ulEeFZQSN0nWF9UU3KZNBBt5+ioZF+xo+UdY+Tg== X-Google-Smtp-Source: ABdhPJx/ZfVvMYfZ+FCpq8mN/ak7knp9oqecpdqTXnT9ha0SaU2h7YOiIPf6heUScFGCEzfQFKq6ul5th2pENytVQSI= X-Received: by 2002:ac2:548e:: with SMTP id t14mr1584706lfk.617.1624494382952; Wed, 23 Jun 2021 17:26:22 -0700 (PDT) MIME-Version: 1.0 References: <03f7955c-69a8-4841-9245-449d7851e207@www.fastmail.com> In-Reply-To: Date: Thu, 24 Jun 2021 01:26:12 +0100 Message-ID: To: Bruce Weirdan Cc: Larry Garfield , Scott Arciszewski , php internals Content-Type: multipart/alternative; boundary="000000000000a2c4b805c578129f" Subject: Re: [PHP-DEV] [RFC] Name issue - is_literal/is_trusted From: craig@craigfrancis.co.uk (Craig Francis) --000000000000a2c4b805c578129f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 24 Jun 2021 at 1:09 am, Bruce Weirdan wrote: > > - String + int concatenation isn't an injection risk. > > I think this demonstrates it very well could be: > https://externals.io/message/114988#115038 That=E2=80=99s the developer choosing to use a variable, and it=E2=80=99s n= o different than the developer using a library to add the value via proper quoting/escaping. Craig --000000000000a2c4b805c578129f--