Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115086
MIME-Version: 1.0
References: <CAGBsUrcvMMeYt6NPqfDbPjBZZLLeGonP73p=sHjnc30Unri7uQ@mail.gmail.com>
 <CAESVnVow=DtQ85-jcTH2F9dXVHavpUYL0-ntKYaP=Q507wKMXw@mail.gmail.com>
In-Reply-To: <CAESVnVow=DtQ85-jcTH2F9dXVHavpUYL0-ntKYaP=Q507wKMXw@mail.gmail.com>
Date: Wed, 23 Jun 2021 21:01:56 -0300
Message-ID: <CAEsg9X0BSG+VDsQWTONKMKWnJ-NAZcuAR_tO-UPjSnPvZqDMZw@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000f1d7b405c577bb9c"
Subject: Re: [PHP-DEV] [RFC] Add parse_query_string as an alternative to parse_str
From: david.proweb@gmail.com (David Rodrigues)

--000000000000f1d7b405c577bb9c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I really prefer the Sara suggestion, instead of creating a new function
to do the same thing. parse_str($str): array.


Atenciosamente,
David Rodrigues


Em qua., 23 de jun. de 2021 =C3=A0s 20:20, Sara Golemon <pollita@php.net>
escreveu:

> On Wed, Jun 23, 2021 at 5:02 PM Kamil Tekiela <tekiela246@gmail.com>
> wrote:
>
> > I would like to propose a new simple RFC that aims to add a new functio=
n
> > called parse_query_string as an alternative to parse_str.
> >
> > https://wiki.php.net/rfc/parse_str_alternative
> >
> > The functionality stays the same, only the name and the way of returnin=
g
> > the array changes. While it is a rather insignificant change, I believe
> it
> > is one step closer to making PHP cleaner.
> >
> >
> There's a potential alternative option that doesn't require adding a new,
> parallel function.  We can use execute_data->return_value_used to figure
> out if parse_str() was called with the result assigned to a local var.
> This is overloady and probably a bad idea, but it's an option.
>
> if (ZEND_NUM_ARGS() =3D=3D 2) {
>   // Put result into by-ref second arg
>   // parse_str($str, $refResult);
> } else if (EX(return_value_used)) {
>   // Put result into return_value
>   // $result =3D parse_str($str);
> } else {
>   // Put result into EG(local_symbol_table)
>   // parse_str($str);
>   php_error(E_DEPRECATED, ...);
> }
>
> Realistically, your approach is probably better simply because it doesn't
> depend on the assignment as a side-effect, and it'll be good to have a
> migration route, especially one which gives us a function with, frankly, =
a
> much better name.
>
> That said, and I'll sound like a broken record here, but this is another
> case of being something that can be sorted in userspace trivially:
>
> function parse_query_string(string $str): array {
>   parse_str($str, $ret);
>   return $ret;
> }
>
> Kinda +/- 0 on it at the moment.  I'm less hostile to it than
> str_contains()/str_left()/str_right()/etc...
>
> -Sara
>

--000000000000f1d7b405c577bb9c--