Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115085
To: "internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: [PHP-DEV] [RFC] clamp
Thread-Index: AQHXaF+YZ/LptmFjT0KKwGBdqqQTnqsiPoTj
Date: Wed, 23 Jun 2021 23:50:29 +0000
Message-ID:
 <DM6PR07MB66183FB2B720E47E95DA6615F9089@DM6PR07MB6618.namprd07.prod.outlook.com>
References: <0BBAA2F7-02D7-4AEE-B48A-97436A0D8E5D@gmail.com>
In-Reply-To: <0BBAA2F7-02D7-4AEE-B48A-97436A0D8E5D@gmail.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [mCo2YvdqyVqnuQGAr/8gLRdrqVFvK2HKW47P/KRm4ALsYSmixKe3duzXlp4yNTUn]
x-ms-publictraffictype: Email
x-incomingheadercount: 44
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: f5ed2ab1-8263-49c3-13dd-08d936a1aed8
x-ms-traffictypediagnostic: DM6NAM10HT027:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 493DeDha7ojXySzLkf/hKo0s5RpRGADoAvMh6qBFf3rrykIxic1t+6MaH+dylTgl6fi0wizdFE61ZTZuyGT1s0Ze1YBP9BpvuAXTZcsYcggLEe4qzogiYhQYDeHyd5u6ydz8f7H2aOMXZJ7V5+nOSljOIGaDNoIvNhhvhFImLeu8faVwWahcDXlauzuqbcsh2O4fLvhrZvF/MEB+Jcgl0UF5bf6QmCEWQ2L9Ai0HeLSBSmcqje2AIAGibIV99HJ7PrYVM1XI2z3z80UTIhrWcHBlT/1UX5LOO9P4G4DopNFaolUo3Bd63x5+iC8HKrWLh3vN5U96XkJkrjfzutfVSbi0bOf63pI55TldaCyxDpyY3uofqV7iXtN6OL9bpsMqQSjPyTbgVgrBTc7JJLSKiqW9lAtX4Sf+MfiLMqjDNaiX3r/gkVKNOVVvOMVawNfKFUUoG3nN24z0cY27KOqF7A==
x-ms-exchange-antispam-messagedata:
 ryhQwSBh5+6vv9npo+knKBReD4nWwxOekYSHVJEqAdfKj/bKRivXoIF/ivdUy/rwkQuuVvE+FpxXrxrDm1n4iGQzaUOa+OBjDfn4b/S/HTqpYL5xBqfcKAMiu+Q0U3nXINIKx4WdNS3t69DpJYRx06c0ugsu3ojzqPvNVx9ipitshcS/tPuKsc7MVbB1kJ307MneTuELjjsckL3rvkC0Bw==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM10FT013.eop-nam10.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: f5ed2ab1-8263-49c3-13dd-08d936a1aed8
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2021 23:50:29.9667
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM10HT027
Subject: Re: [PHP-DEV] [RFC] clamp
From: tysonandre775@hotmail.com (tyson andre)

Hi Kim Hallberg,=0A=
=0A=
> The RFC for the clamp function is now open and under discussion, you now =
have 2 weeks =0A=
> to discuss, suggest improvements and open issues before voting is conside=
red.=0A=
> =0A=
> Any and all feedback is welcomed.=0A=
> =0A=
> The RFC is available for viewing here: https://wiki.php.net/rfc/clamp=0A=
> The implementation is available in a PR here: https://github.com/php/php-=
src/pull/7191=0A=
=0A=
https://wiki.php.net/rfc/howto mentions:=0A=
=0A=
> Listen to the feedback, and try to answer/resolve all questions.=0A=
> **Update your RFC to document all the issues and discussions.=0A=
> Cover both the positive and negative arguments.** Put the RFC URL into al=
l your replies.=0A=
=0A=
So I think the major objections are that:=0A=
=0A=
1. This is easy to implement in userland and there's negligible performance=
 benefit=0A=
   (in code that is a performance sensitive loop, it may still be worse com=
pared to `$num < $min ? $min : ($num > $max : $max : $num)` when validity o=
f types and min/max are known, especially with the JIT)=0A=
2. People not being sure if they'd ever use it personally, especially with =
the ability to customize parameter order and permitted argument types in us=
erland=0A=
3. It's inconsistent with min() and max(), which support any comparable typ=
e such as GMP(https://www.php.net/manual/en/class.gmp)=0A=
   (arbitrary precision numbers), DateTime, etc., and that may lead to surp=
rises.=0A=
   Although PHP's comparison operator and https://www.php.net/manual/en/fun=
ction.min.php have many, many inconsistencies, already=0A=
=0A=
   (Though special casing GMP is probably a bad idea due to it being option=
al and having an incompatible license with core for packagers)=0A=
4. I'm not sure what this is meant to do with the float NAN (Not A Number) =
from the RFC description, but that's solvable=0A=
=0A=
```=0A=
php > var_dump(min(gmp_init('123'), gmp_init('456')));=0A=
object(GMP)#1 (1) {=0A=
  ["num"]=3D>=0A=
  string(3) "123"=0A=
}=0A=
php > var_dump(max(new DateTime('@0'), new DateTime()));=0A=
object(DateTime)#2 (3) {=0A=
  ["date"]=3D>=0A=
  string(26) "2021-06-23 23:44:47.302531"=0A=
  ["timezone_type"]=3D>=0A=
  int(3)=0A=
  ["timezone"]=3D>=0A=
  string(3) "UTC"=0A=
}=0A=
php > echo json_encode(max([0,2],[0,1]));=0A=
[0,2]=0A=
```=0A=
=0A=
The RFC should probably link to this RFC announcement thread https://extern=
als.io/message/115076 as well.=0A=
=0A=
Thanks,=0A=
Tyson=