Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:115083
MIME-Version: 1.0
References: <CAGBsUrcvMMeYt6NPqfDbPjBZZLLeGonP73p=sHjnc30Unri7uQ@mail.gmail.com>
In-Reply-To: <CAGBsUrcvMMeYt6NPqfDbPjBZZLLeGonP73p=sHjnc30Unri7uQ@mail.gmail.com>
Date: Wed, 23 Jun 2021 18:19:55 -0500
Message-ID: <CAESVnVow=DtQ85-jcTH2F9dXVHavpUYL0-ntKYaP=Q507wKMXw@mail.gmail.com>
To: Kamil Tekiela <tekiela246@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000a56b7a05c5772553"
Subject: Re: [PHP-DEV] [RFC] Add parse_query_string as an alternative to parse_str
From: pollita@php.net (Sara Golemon)

--000000000000a56b7a05c5772553
Content-Type: text/plain; charset="UTF-8"

On Wed, Jun 23, 2021 at 5:02 PM Kamil Tekiela <tekiela246@gmail.com> wrote:

> I would like to propose a new simple RFC that aims to add a new function
> called parse_query_string as an alternative to parse_str.
>
> https://wiki.php.net/rfc/parse_str_alternative
>
> The functionality stays the same, only the name and the way of returning
> the array changes. While it is a rather insignificant change, I believe it
> is one step closer to making PHP cleaner.
>
>
There's a potential alternative option that doesn't require adding a new,
parallel function.  We can use execute_data->return_value_used to figure
out if parse_str() was called with the result assigned to a local var.
This is overloady and probably a bad idea, but it's an option.

if (ZEND_NUM_ARGS() == 2) {
  // Put result into by-ref second arg
  // parse_str($str, $refResult);
} else if (EX(return_value_used)) {
  // Put result into return_value
  // $result = parse_str($str);
} else {
  // Put result into EG(local_symbol_table)
  // parse_str($str);
  php_error(E_DEPRECATED, ...);
}

Realistically, your approach is probably better simply because it doesn't
depend on the assignment as a side-effect, and it'll be good to have a
migration route, especially one which gives us a function with, frankly, a
much better name.

That said, and I'll sound like a broken record here, but this is another
case of being something that can be sorted in userspace trivially:

function parse_query_string(string $str): array {
  parse_str($str, $ret);
  return $ret;
}

Kinda +/- 0 on it at the moment.  I'm less hostile to it than
str_contains()/str_left()/str_right()/etc...

-Sara

--000000000000a56b7a05c5772553--