Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:115044 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 22961 invoked from network); 22 Jun 2021 20:16:59 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 22 Jun 2021 20:16:59 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id DD2951804E3 for ; Tue, 22 Jun 2021 13:35:18 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 22 Jun 2021 13:35:18 -0700 (PDT) Received: by mail-qt1-f177.google.com with SMTP id g12so480571qtb.2 for ; Tue, 22 Jun 2021 13:35:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1URj8KqDOdSPTZZd9S2Z7L026LyeVb6ZKxlUThgvQ0M=; b=gahhJ+BRFVtU2R6ZM27vqIWjlaqv6oUDM6T6Q2TIuSTkqJYKknrfiOCGCeCthsGNpP UJu/Fvp7mG7MX/RJVAax4ZZyKIPnnzGobg6YC0WLHXkJhDiQ7lQ8QVwWbS/dfCDpOlwH d/JcQFecmUoHWNBo7DzXiFQTyQB0s/fuDaa9l0fwCRK81usQcG5N41/f1TCnX1ZmTDFT 7gy7sXnukYkYBRJ5J0dzAjtaYcOcWSaTKHkKAD/knzI5lZlDUWkYbD88a0dj7fcaI3L6 oIEuNWcFGw20GSEZyH2idkAl4JllUVfhFXc5TtXGVmzfjZQds8dlJtXuPtLibhGuddpx bcyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1URj8KqDOdSPTZZd9S2Z7L026LyeVb6ZKxlUThgvQ0M=; b=jv/EX5e9PjjnR3qiVZmsX+T4NSSxM6wnZA+CDYRGJY9qSRLILKhYaEmdATP1bVoWvH bLp3y22Sm2v33AC9Tw1t33AZvtAswWQG7pB6+R5aU/7sz1xZZRqrSvKq/k+L5/30HhAu 1H6gh4Sue5mPEhExzOFS0F2Pfd3DMu4iANgm1MBZEjnyjmgrgeprkCtUB/6+gvSqfyMI ioXEXil5eFuuLFzYyTLPZZt9TE01J1+eVHJaO0axvnmfz4ZfaEm3AMMbKqj/RPh7hBQ0 w2gcMdhid31mvDlbbFG9NniNt337SIpI9mJHCdDEC/8ssyRkOT9sDRUn+LIyUXQ/YdnJ FjoQ== X-Gm-Message-State: AOAM531JH1XtN4iMp7m4jFbpp5ncrOc1gOSGWBTaSDZhrlV21caBKtLg 1+zNQLMXT7G4/aCpyhop4j3IT8TbJIoZumO6OwYdo/+SCDEZUHAO X-Google-Smtp-Source: ABdhPJw7pU5qtLUJrnbg9rQZIUlC4kN+uYpwSMv0oID5K3olFNhOD96wTLx9nSBCk3hzkBMqH+E0ZmvxsifYZLRKRIY= X-Received: by 2002:ac8:7eef:: with SMTP id r15mr560035qtc.277.1624394115608; Tue, 22 Jun 2021 13:35:15 -0700 (PDT) MIME-Version: 1.0 References: <60ACEB8C-43F7-4ED4-8365-01AC9F6CB544@php.net> In-Reply-To: <60ACEB8C-43F7-4ED4-8365-01AC9F6CB544@php.net> Date: Tue, 22 Jun 2021 21:35:04 +0100 Message-ID: To: Derick Rethans Cc: Craig Francis , PHP internals Content-Type: multipart/alternative; boundary="0000000000003c763305c560ba75" Subject: Re: [PHP-DEV] [RFC] Name issue - is_literal/is_trusted From: tekiela246@gmail.com (Kamil Tekiela) --0000000000003c763305c560ba75 Content-Type: text/plain; charset="UTF-8" FWIW, I would prefer is_literal, but without integers in scope. Modern code is often type hinted. I would expect that a lot of libraries would accept only strings and then check whether it's a literal string. I don't think accepting integers in scope increases security or improves ease of use. However, I am more concerned about other things that have been mentioned in this thread and the overall disagreement. I'd rather not rush this change. Also, I am concerned about the performance of applications that are heavy on string processing. Although I haven't tested this yet myself. --Kamil --0000000000003c763305c560ba75--