Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:11498 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 97800 invoked by uid 1010); 23 Jul 2004 06:44:55 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 97774 invoked from network); 23 Jul 2004 06:44:55 -0000 Received: from unknown (HELO mx.thebrainroom.net) (69.55.226.195) by pb1.pair.com with SMTP; 23 Jul 2004 06:44:55 -0000 Received: by mx.thebrainroom.net (Postfix, from userid 517) id A593A1488035; Thu, 22 Jul 2004 23:44:54 -0700 (PDT) Received: from BAUMBART (p508EA72E.dip.t-dialin.net [80.142.167.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by mx.thebrainroom.net (Postfix) with ESMTP id A0B1A1488033; Thu, 22 Jul 2004 23:44:51 -0700 (PDT) Date: Fri, 23 Jul 2004 08:44:56 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <1938036338.20040723084456@marcus-boerger.de> To: Andi Gutmans Cc: internals@lists.php.net In-Reply-To: <5.1.0.14.2.20040722142013.02cd0890@127.0.0.1> References: <5.1.0.14.2.20040722142013.02cd0890@127.0.0.1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on jc.thebrainroom.net X-Spam-Status: No, hits=0.8 required=5.0 tests=PRIORITY_NO_NAME autolearn=no version=2.63 X-Spam-Level: X-TBR-Filter: Virus scanned and defanged Subject: Re: [PHP-DEV] Memory leak From: helly@php.net (Marcus Boerger) Hello Andi, the easiest way to make the test suit for 5.1 work again is to change zend_execute.c line 1352 to: EX(Ts) = (temp_variable *) safe_emalloc(sizeof(temp_variable), op_array->T, 1); notice the 1 instead of 0 which allocates one additional byte for every execution. regards marcus Thursday, July 22, 2004, 11:25:57 PM, you wrote: > The executor() change from alloca() to emalloc() seems to have introduced a > memory leak (found it with --enable-debug). Before I try and fix it, are we > reverting back to do_alloca(), free_alloca()? (even though we should see > why this memory leak is happening anyway because we don't always use > alloca() for do_allocat()). > Andi -- Best regards, Marcus mailto:helly@php.net