Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:114955
MIME-Version: 1.0
Date: Fri, 18 Jun 2021 17:35:48 +0300
Message-ID: <CAMSJsBDdfnbge_digZVPfUme2y1V-XGmstUzpTmk9zJ1R7fdRQ@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000fadcd605c50b3d01"
Subject: Checking that Closure is static
From: elisdnru@gmail.com (=?UTF-8?B?0JTQvNC40YLRgNC40Lkg0JXQu9C40YHQtdC10LI=?=)

--000000000000fadcd605c50b3d01
Content-Type: text/plain; charset="UTF-8"

Hello! When I use a static anonymous function as an HTTP-action in
some frameworks like:

$app = new App();
$app->get('/', static function () {
   return new Response('Hello!);
})

I get a warning "Cannot bind an instance to a static closure" in every
$closure->bind($container) call inside of the framework.

But right now I cannot prevent this warning because there is no native
way to check that closure is static before calling the bind method. I
can only suppress the warning with @ or set/restore_error_handler
pair.

So I propose to add a method like Closure::isStatic (or
Closure::canBeBound, etc.) for ability of manual checking it before
bind call:

if (!$closure->isStatic()) {
   $closure->bind($object);
}

The method can contain simple statement:

return func->common.fn_flags & ZEND_ACC_STATIC;

It will be helpful if somebody needs to support dynamic and static
callables both without warnings.

-- Best, Dmitry

--000000000000fadcd605c50b3d01--